ironic-lib

remove i18n methods because logs are not being translated

Bug #1674374 reported by Ruby Loo
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Ironic
Fix Released
Low
Ngo Quoc Cuong
Ironic Inspector
Fix Released
Low
Annie Lezil
Python client for Ironic Inspector
Fix Released
Low
Tao Li
ironic-lib
Fix Released
Low
John L. Villalovos
ironic-staging-drivers
Fix Released
Low
Ngo Quoc Cuong
python-ironicclient
Fix Released
Low
Tao Li

Bug Description

The i18n team has decided not to translate the logs because it seems like it not very useful; operators prefer to have them in English so that they can search for those strings on the internet.

See http://lists.openstack.org/pipermail/openstack-dev/2017-March/thread.html#113365.

Translation cleanup is being organized here. https://etherpad.openstack.org/p/ironic-translation-cleanup

See original description
Revision history for this message
Michael Turek (mjturek) wrote :

Nova has removed the requirement for translating logs from their hacking job https://review.openstack.org/#/c/446452/

Looks like there are some in flight patches to remove _LE and _LW function calls as well. Moving to confirmed!

Changed in ironic:
status: New → Incomplete
status: Incomplete → Confirmed
Changed in ironic-lib:
status: New → Confirmed
Changed in ironic:
importance: Undecided → High
Changed in ironic-lib:
importance: Undecided → High
John L. Villalovos (happycamp)
Changed in ironic-lib:
assignee: nobody → John L. Villalovos (happycamp)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-lib (master)

Fix proposed to branch: master
Review: https://review.openstack.org/447633

Changed in ironic-lib:
status: Confirmed → In Progress
Annie Lezil (annie-lezil)
Changed in ironic-inspector:
status: New → Confirmed
importance: Undecided → High
assignee: nobody → Annie Lezil (annie-lezil)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/447642

Changed in ironic:
assignee: nobody → Varun Gadiraju (varun-gadiraju)
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/447727

Changed in ironic:
assignee: Varun Gadiraju (varun-gadiraju) → Ramamani Yeleswarapu (ramamani-yeleswarapu)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-inspector (master)

Fix proposed to branch: master
Review: https://review.openstack.org/447884

Changed in ironic-inspector:
status: Confirmed → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/448089

Changed in ironic:
assignee: Ramamani Yeleswarapu (ramamani-yeleswarapu) → Michael Turek (mjturek)
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Michael Turek (mjturek) → Varun Gadiraju (varun-gadiraju)
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Varun Gadiraju (varun-gadiraju) → Michael Turek (mjturek)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-inspector (master)

Fix proposed to branch: master
Review: https://review.openstack.org/448221

Revision history for this message
Ruby Loo (rloo) wrote :

This isn't a high bug. In fact, we could just leave the code as-is and it wouldn't matter. We want to clean it up so things are consistent, etc.

Changed in ironic:
importance: High → Low
Changed in ironic-inspector:
importance: High → Low
Changed in ironic-lib:
importance: High → Low
Revision history for this message
Ruby Loo (rloo) wrote :

Someone had an etherpad which I thought was being used to coordinate who was doing what. Would someone please add that to this bug if that is true.

in general, it would be nice if folks would update the bug with whatever information might be useful.

Revision history for this message
Annie Lezil (annie-lezil) wrote :

Yeah Ruby, There is a etherpad, link to it https://etherpad.openstack.org/p/ironic-translation-cleanup

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/448275

Changed in ironic:
assignee: Michael Turek (mjturek) → Adam Kimball (elbaha)
assignee: Adam Kimball (elbaha) → Ramamani Yeleswarapu (ramamani-yeleswarapu)
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Ramamani Yeleswarapu (ramamani-yeleswarapu) → Adam Kimball (elbaha)
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Adam Kimball (elbaha) → Varun Gadiraju (varun-gadiraju)
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Varun Gadiraju (varun-gadiraju) → Michael Turek (mjturek)
Michael Turek (mjturek)
description: updated
Kaifeng Wang (kaifeng)
Changed in python-ironicclient:
assignee: nobody → Wang KaiFeng (kaifeng)
status: New → In Progress
Revision history for this message
Kaifeng Wang (kaifeng) wrote :

I think someone is working on python-ironicclient.
https://review.openstack.org/#/c/447806/

Please update accordingly.

Changed in python-ironicclient:
assignee: Wang KaiFeng (kaifeng) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-lib (master)

Reviewed: https://review.openstack.org/447633
Committed: https://git.openstack.org/cgit/openstack/ironic-lib/commit/?id=254757340785ef297b67292f67e73ce2e3014b6a
Submitter: Jenkins
Branch: master

commit 254757340785ef297b67292f67e73ce2e3014b6a
Author: John L. Villalovos <email address hidden>
Date: Mon Mar 20 11:14:11 2017 -0700

    Remove translation of log messages

    Remove translation of log messages. Log messages will no longer be
    translated.

    Closes-Bug: #1674374
    Change-Id: I66791c08e335c5c5dd7b65a8df6e2132192630a2

Changed in ironic-lib:
status: In Progress → Fix Released
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Michael Turek (mjturek) → Ramamani Yeleswarapu (ramamani-yeleswarapu)
KS Kim (kiseok7)
Changed in python-ironicclient:
assignee: nobody → Kiseok Kim (kiseok7)
KS Kim (kiseok7)
Changed in python-ironicclient:
assignee: Kiseok Kim (kiseok7) → nobody
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/448275
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=b6dcd7635d5e45d1575eb4ac7dcab67606c2b029
Submitter: Jenkins
Branch: master

commit b6dcd7635d5e45d1575eb4ac7dcab67606c2b029
Author: Adam Kimball <email address hidden>
Date: Tue Mar 21 16:42:37 2017 -0400

    Remove log translation function calls from ironic.db

    Remove all calls to logging functions from the db directory of ironic.
    In this instance, there were very few, and all were to _LW.

    Change-Id: I474f2d51bf7cb9d6082d963de182d4a1fed142b3
    Partial-bug: #1674374

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/450036

Changed in ironic:
assignee: Ramamani Yeleswarapu (ramamani-yeleswarapu) → Anup (anup-d-navare)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-inspector (master)

Reviewed: https://review.openstack.org/447884
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=c06a9a7f2496c0e84a9cca4aa2714067a95dfd01
Submitter: Jenkins
Branch: master

commit c06a9a7f2496c0e84a9cca4aa2714067a95dfd01
Author: Annie Lezil <email address hidden>
Date: Tue Mar 21 06:35:55 2017 +0000

    Remove translation of log messages Part-1

    The i18n team has decided not to translate the logs because it seems
    like it not very useful.

    This are the files as of now do not have merge conflicts.

    Change-Id: I082f6302f120a8c0c81482b73be301e83fe3a3a8
    Partial-Bug: #1674374

Revision history for this message
Anton Arefiev (aarefiev) wrote :

patch for python-ironic-inspector-client https://review.openstack.org/#/c/447801/

Changed in python-ironic-inspector-client:
status: New → In Progress
importance: Undecided → Low
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Anup (anup-d-navare) → Michael Turek (mjturek)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic-lib 2.7.0

This issue was fixed in the openstack/ironic-lib 2.7.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/447727
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=d82fb9a9a2817ef5b7a6c91115e2b2bf5cfebebc
Submitter: Jenkins
Branch: master

commit d82fb9a9a2817ef5b7a6c91115e2b2bf5cfebebc
Author: Ramamani Yeleswarapu <email address hidden>
Date: Mon Mar 20 16:29:03 2017 -0700

    Remove translation of log messages from ironic/conductor

    The i18n team has decided not to translate the logs because it seems
    like it's not very useful.

    This patch removes translation of log messages from ironic/conductor.

    Change-Id: I0fabef88f2d1bc588150f02cac0f5e975965fc29
    Partial-Bug: #1674374

Tao Li (eric-litao)
Changed in python-ironic-inspector-client:
assignee: nobody → Tao Li (eric-litao)
Changed in python-ironicclient:
assignee: nobody → Tao Li (eric-litao)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-inspector (master)

Reviewed: https://review.openstack.org/448221
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=1e6b68928678aea0ff28d6dbf5d0e0cbd42df272
Submitter: Jenkins
Branch: master

commit 1e6b68928678aea0ff28d6dbf5d0e0cbd42df272
Author: Annie Lezil <email address hidden>
Date: Tue Mar 21 18:14:57 2017 +0000

    Remove translation of log messages Part-2

    The i18n team has decided not to translate the logs because it seems
    like it not very useful.

    Change-Id: I46c1b0c3efa28c3f887b1a29dc77d47fe749be87
    Closes-Bug: #1674374

Changed in ironic-inspector:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic-inspector 5.1.0

This issue was fixed in the openstack/ironic-inspector 5.1.0 release.

OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Michael Turek (mjturek) → Varun Gadiraju (varun-gadiraju)
Vladyslav Drok (vdrok)
Changed in python-ironicclient:
importance: Undecided → Low
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/453360

Changed in ironic:
assignee: Varun Gadiraju (varun-gadiraju) → Joanna Taryma (jtaryma)
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Joanna Taryma (jtaryma) → Anup (anup-d-navare)
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Anup (anup-d-navare) → Varun Gadiraju (varun-gadiraju)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ironic-inspector-client (master)

Reviewed: https://review.openstack.org/447801
Committed: https://git.openstack.org/cgit/openstack/python-ironic-inspector-client/commit/?id=2df805d71df39ec04899bf4e0fb6375c0ccf281e
Submitter: Jenkins
Branch: master

commit 2df805d71df39ec04899bf4e0fb6375c0ccf281e
Author: Tao Li <litao3721@126.com>
Date: Tue Mar 21 12:57:23 2017 +0800

    Remove log translations

    Log messages are no longer being translated. This removes all use of the
    _LE, _LI, and _LW translation markers to simplify logging and to avoid
    confusion with new contributions. See:
    http://lists.openstack.org/pipermail/openstack-i18n/2016-November/002574.html
    http://lists.openstack.org/pipermail/openstack-dev/2017-March/113365.html

    Change-Id: I1aff184cb8b41de739a5716c2c45ced9a10e5b52
    Closes-Bug: #1674374

Changed in python-ironic-inspector-client:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/447642
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=a232586757067c8066c9782faae0f9f4a9537633
Submitter: Jenkins
Branch: master

commit a232586757067c8066c9782faae0f9f4a9537633
Author: Varun Gadiraju <email address hidden>
Date: Mon Mar 20 18:35:58 2017 +0000

    Remove translation of log messages from ironic/dhcp and ironic/cmd

    i18n team has decided not to translate the logs because it seems
    like it's not very useful. Removed translation of log messages
    from ironic/dhcp and ironic/cmd

    Change-Id: I63d4536cf23330a7656fc2f5c597c33b2cf1ae94
    Partial-Bug: #1674374

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/453360
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=474d0909dbb12322cdd33a7385a6ac7dc506dbf0
Submitter: Jenkins
Branch: master

commit 474d0909dbb12322cdd33a7385a6ac7dc506dbf0
Author: Joanna Taryma <email address hidden>
Date: Wed Apr 5 09:53:58 2017 -0700

    Remove translation of log messages from ironic/api

    The i18n team has decided not to translate the logs because it seems
    like it's not very useful.

    This patch removes translation of log messages from ironic/api.

    Change-Id: Icddd5918f9c9b6d80d4e9b1cbbae13ecebd52988
    Partial-Bug: #1674374

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/457196

Changed in ironic:
assignee: Varun Gadiraju (varun-gadiraju) → Shivanand Tendulker (stendulker)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/459627

Changed in ironic:
assignee: Shivanand Tendulker (stendulker) → Tuan (tuanla)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/459629

Changed in ironic:
assignee: Tuan (tuanla) → Ngo Quoc Cuong (cuongnq)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/459629
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=4e6b8347777ed50edd562a9660ab0faefc3d237f
Submitter: Jenkins
Branch: master

commit 4e6b8347777ed50edd562a9660ab0faefc3d237f
Author: Ngo Quoc Cuong <email address hidden>
Date: Tue Apr 25 19:00:25 2017 +0700

    Remove translation of log messages from ironic/drivers/modules/ucs

    i18n team has decided not to translate the logs because it seems
    like it's not very useful. Removed translation of log messages
    from ironic/drivers/modules/ucs

    Change-Id: I68cb6f1b91588d4facd8ffed3fc9612e13f529a2
    Partial-Bug: #1674374

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/459627
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=4ba2bb282812472fb07167235f2a62387db2352d
Submitter: Jenkins
Branch: master

commit 4ba2bb282812472fb07167235f2a62387db2352d
Author: Luong Anh Tuan <email address hidden>
Date: Wed Apr 26 00:34:30 2017 +0700

    Remove translation of log messages from ironic/drivers/modules/irmc

    i18n team has decided not to translate the logs because it seems
    like it's not very useful. Removed translation of log messages
    from ironic/drivers/modules/irmc

    Change-Id: I0343fd4ee40c9166bab6376aac76d54066a8296a
    Partial-Bug: #1674374

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to python-ironicclient (master)

Reviewed: https://review.openstack.org/447806
Committed: https://git.openstack.org/cgit/openstack/python-ironicclient/commit/?id=ee94c48806a868bff8966ce9720bccaf3138ce6c
Submitter: Jenkins
Branch: master

commit ee94c48806a868bff8966ce9720bccaf3138ce6c
Author: Tao Li <litao3721@126.com>
Date: Tue Mar 21 13:05:58 2017 +0800

    Remove log translations

    Log messages are no longer being translated. This removes all use of the
    _LE, _LI, and _LW translation markers to simplify logging and to avoid
    confusion with new contributions. See:
    http://lists.openstack.org/pipermail/openstack-i18n/2016-November/002574.html
    http://lists.openstack.org/pipermail/openstack-dev/2017-March/113365.html

    Change-Id: I0a2263090899a86ff922f00feb92d440f9226c4b
    Closes-Bug: #1674374

Changed in python-ironicclient:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/459909

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/459910

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/459918

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/459925

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Fix proposed to branch: master
Review: https://review.openstack.org/459936

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Ngo Quoc Cuong (<email address hidden>) on branch: master
Review: https://review.openstack.org/459910
Reason: will be merged to https://review.openstack.org/#/c/459925/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Ngo Quoc Cuong (<email address hidden>) on branch: master
Review: https://review.openstack.org/459909

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/460367

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Ngo Quoc Cuong (<email address hidden>) on branch: master
Review: https://review.openstack.org/459918

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Ngo Quoc Cuong (<email address hidden>) on branch: master
Review: https://review.openstack.org/459925

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/460378

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/457196
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=1dedfdb7b75e5b766e8a70d176ed75616698c440
Submitter: Jenkins
Branch: master

commit 1dedfdb7b75e5b766e8a70d176ed75616698c440
Author: Shivanand Tendulker <email address hidden>
Date: Mon Apr 17 06:30:18 2017 -0400

    Remove log translations from iLO drivers

    Log messages are no longer being translated. This removes the use of
    _LE, _LI and _LW translation markers from iLO drivers code.

    Change-Id: Iba1158ae793ba3530e74af5941a24d833050be8e
    Partial-Bug: #1674374

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Ngo Quoc Cuong (<email address hidden>) on branch: master
Review: https://review.openstack.org/460378
Reason: Will be merged to https://review.openstack.org/#/c/460367/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Change abandoned by Ngo Quoc Cuong (<email address hidden>) on branch: master
Review: https://review.openstack.org/459936

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic (master)

Fix proposed to branch: master
Review: https://review.openstack.org/460841

Ngo Quoc Cuong (cuongngoquoc)
Changed in glance:
assignee: nobody → Ngo Quoc Cuong (cuongnq)
Ngo Quoc Cuong (cuongngoquoc)
no longer affects: glance
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Ngo Quoc Cuong (cuongnq) → Anup (anup-d-navare)
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Anup (anup-d-navare) → Ngo Quoc Cuong (cuongnq)
OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Ngo Quoc Cuong (cuongnq) → Anup (anup-d-navare)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-ironicclient 1.13.0

This issue was fixed in the openstack/python-ironicclient 1.13.0 release.

OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Anup (anup-d-navare) → Michael Turek (mjturek)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/450036
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=4c82308ebed809352674959a3892f8b3bac01d1b
Submitter: Jenkins
Branch: master

commit 4c82308ebed809352674959a3892f8b3bac01d1b
Author: Anup Navare <email address hidden>
Date: Sun Mar 26 19:01:10 2017 +0000

    Remove log translations from ironic/drivers Part-1

    Log messages are no longer being translated. This removes the use of
    _LE, _LI and _LW translation markers from ironic/drivers.

    Change-Id: Ie01c1a6a0e0232dce055767854a5d4385b392510
    Partial-Bug: #1674374

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Change abandoned on ironic (master)

Change abandoned by Ngo Quoc Cuong (<email address hidden>) on branch: master
Review: https://review.openstack.org/460841
Reason: duplicate with: https://review.openstack.org/#/c/450036/

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/448089
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=5777f4ab8c21eb93d720f57a980a594bdda0a8fd
Submitter: Jenkins
Branch: master

commit 5777f4ab8c21eb93d720f57a980a594bdda0a8fd
Author: Michael Turek <email address hidden>
Date: Tue Mar 21 09:00:27 2017 -0400

    Remove logging translation calls from ironic.common

    Removes calls to _LE, _LW, and _LI used for translating
    logs. There were no _LC calls in this directory.

    Change-Id: If74114cb5b28bac89ea66ee068799d0a3cea38df
    Partial-bug: #1674374

OpenStack Infra (hudson-openstack)
Changed in ironic:
assignee: Michael Turek (mjturek) → Ngo Quoc Cuong (cuongnq)
Revision history for this message
OpenStack Infra (hudson-openstack) wrote :

Reviewed: https://review.openstack.org/460367
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=7d59d48039f54f62488d07f71744da426e8b0d80
Submitter: Jenkins
Branch: master

commit 7d59d48039f54f62488d07f71744da426e8b0d80
Author: Ngo Quoc Cuong <email address hidden>
Date: Thu Apr 27 10:06:07 2017 +0700

    Remove translation of log messages

    The i18n team has decided not to translate the logs because it
    seems like it not very useful; operators prefer to have them in
    English so that they can search for those strings on the internet.

    Change-Id: I2a62525e18a34e3bbbdfe4e8924d0109568e8e72
    Closes-Bug: #1674374

Changed in ironic:
status: In Progress → Fix Released
Ngo Quoc Cuong (cuongngoquoc)
Changed in ironic-staging-drivers:
assignee: nobody → Ngo Quoc Cuong (cuongnq)
status: New → In Progress
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix proposed to ironic-staging-drivers (master)

Related fix proposed to branch: master
Review: https://review.openstack.org/478350

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Related fix merged to ironic-staging-drivers (master)

Reviewed: https://review.openstack.org/478350
Committed: https://git.openstack.org/cgit/openstack/ironic-staging-drivers/commit/?id=722459abb30679ada42f7c3229dcb3b72fb9525e
Submitter: Jenkins
Branch: master

commit 722459abb30679ada42f7c3229dcb3b72fb9525e
Author: Ngo Quoc Cuong <email address hidden>
Date: Tue Jun 27 23:06:38 2017 -0400

    Remove translation of log messages

    The i18n team has decided not to translate the logs because it
    seems like it not very useful; operators prefer to have them in
    English so that they can search for those strings on the internet.

    Change-Id: Ifcb4c4331440d94322a56a1e3bed04cff453cbad
    Related-Bug: #1674374

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/python-ironic-inspector-client 2.0.0

This issue was fixed in the openstack/python-ironic-inspector-client 2.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic (master)

Reviewed: https://review.openstack.org/448196
Committed: https://git.openstack.org/cgit/openstack/ironic/commit/?id=61827da6ff6b824b96d5ab9c5c0bdc993bdbf477
Submitter: Jenkins
Branch: master

commit 61827da6ff6b824b96d5ab9c5c0bdc993bdbf477
Author: Michael Turek <email address hidden>
Date: Tue Mar 21 13:00:56 2017 -0400

    Remove translator assignments from i18n

    We are cleaning out all calls to logging translation wrappers from
    ironic. This patch removes the assignments of _LC, _LE, _LI, and _LW
    from ironic.common.i18n. These must be removed after all the calls to
    them are removed, otherwise there would be failures as the function
    calls would no longer resolve. Dependent patches listed are the
    other standing translation cleanup patches.

    Closes-Bug: #1674374
    Change-Id: I6e44d366cb6754c5c6bdf4a9fdd67dc8b230e397

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix included in openstack/ironic 9.0.0

This issue was fixed in the openstack/ironic 9.0.0 release.

Dmitry Tantsur (divius)
Changed in ironic-staging-drivers:
importance: Undecided → Low
Revision history for this message
Pavlo Shchelokovskyy (pshchelo) wrote :

fixed in ironic-staging-drivers by https://review.openstack.org/#/c/478350/

fix released as part of ironic-staging-drivers 0.7.0 release

Changed in ironic-staging-drivers:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.