Should not "enable_plugin ironic-inspector" in devstack/upgrade/settings

[John L. Villalovos]

If ever desired to do multi-node will need to remove doing 'enable_plugin ironic-inspector' in devstack/upgrade/settings. Also removing it will enable project-config logic to be simpler.

This was done for ironic in this patch:
https://review.openstack.org/442154

With a follow-on change to openstack-infra/project-config:
https://review.openstack.org/443348

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/474344

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/474344
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=69157e5554ef6ad10f3d6d3ffc313d4e498ec21b
Submitter: Jenkins
Branch: master

commit 69157e5554ef6ad10f3d6d3ffc313d4e498ec21b
Author: Ramamani Yeleswarapu <email address hidden>
Date: Wed Jun 14 12:11:16 2017 -0700

    grenade: Only 'enable_plugin ironic-inspector' if not already in conf

    To support multi-node grenade jobs we need to move enabling of the
    ironic-inspector devstack plugin out of the ironic-inspector grenade
    settings file devstack/upgrade/settings. But if we add enabling of the
    ironic-inspector devstack plugin to project-config it will cause the gate
    to break as the plugin will be enabled twice.

    This patch is similar to the change done in ironic for the same purpose.

    This checks to see if the ironic-inspector devstack plugin has already been
    enabled:
      * If it has already been enabled it will not enable it again.
      * If it has not yet been enabled it will enable it.

    This will allow us to update project-config to enable the ironic-inspector
    devstack plugin and not break the gate.

    After all the changes have landed we will propose a follow-up patch to
    remove all this additonal logic and the enabling of the ironic-inspector
    devstack plugin.

    Change-Id: Id1a5de9a8aefe751b63c1a6a9f2c942fe4c957b1
    Closes-Bug: #1672448

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/476725

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/476725
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=da908db4c8633f6c3728701819a98a74635e2073
Submitter: Jenkins
Branch: stable/ocata

commit da908db4c8633f6c3728701819a98a74635e2073
Author: Ramamani Yeleswarapu <email address hidden>
Date: Wed Jun 14 12:11:16 2017 -0700

    grenade: Only 'enable_plugin ironic-inspector' if not already in conf

    To support multi-node grenade jobs we need to move enabling of the
    ironic-inspector devstack plugin out of the ironic-inspector grenade
    settings file devstack/upgrade/settings. But if we add enabling of the
    ironic-inspector devstack plugin to project-config it will cause the gate
    to break as the plugin will be enabled twice.

    This patch is similar to the change done in ironic for the same purpose.

    This checks to see if the ironic-inspector devstack plugin has already been
    enabled:
      * If it has already been enabled it will not enable it again.
      * If it has not yet been enabled it will enable it.

    This will allow us to update project-config to enable the ironic-inspector
    devstack plugin and not break the gate.

    After all the changes have landed we will propose a follow-up patch to
    remove all this additonal logic and the enabling of the ironic-inspector
    devstack plugin.

    Change-Id: Id1a5de9a8aefe751b63c1a6a9f2c942fe4c957b1
    Closes-Bug: #1672448
    (cherry picked from commit 69157e5554ef6ad10f3d6d3ffc313d4e498ec21b)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/478221

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/478221
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=4ff7f72b14c05b8efb31dc266d5f35fefa14172b
Submitter: Jenkins
Branch: stable/newton

commit 4ff7f72b14c05b8efb31dc266d5f35fefa14172b
Author: Ramamani Yeleswarapu <email address hidden>
Date: Wed Jun 14 12:11:16 2017 -0700

    grenade: Only 'enable_plugin ironic-inspector' if not already in conf

    To support multi-node grenade jobs we need to move enabling of the
    ironic-inspector devstack plugin out of the ironic-inspector grenade
    settings file devstack/upgrade/settings. But if we add enabling of the
    ironic-inspector devstack plugin to project-config it will cause the gate
    to break as the plugin will be enabled twice.

    This patch is similar to the change done in ironic for the same purpose.

    This checks to see if the ironic-inspector devstack plugin has already been
    enabled:
      * If it has already been enabled it will not enable it again.
      * If it has not yet been enabled it will enable it.

    This will allow us to update project-config to enable the ironic-inspector
    devstack plugin and not break the gate.

    After all the changes have landed we will propose a follow-up patch to
    remove all this additonal logic and the enabling of the ironic-inspector
    devstack plugin.

    Change-Id: Id1a5de9a8aefe751b63c1a6a9f2c942fe4c957b1
    Closes-Bug: #1672448
    (cherry picked from commit 69157e5554ef6ad10f3d6d3ffc313d4e498ec21b)

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: master
Review: https://review.openstack.org/479378

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/479378
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=74e27b9bf3c86642779a199f4de1f1b6ccea04d0
Submitter: Jenkins
Branch: master

commit 74e27b9bf3c86642779a199f4de1f1b6ccea04d0
Author: Ramamani Yeleswarapu <email address hidden>
Date: Fri Jun 30 10:22:44 2017 -0700

    [Devstack] cleanup upgrade settings

    We now enable plugin and services in project-config.
    Drop those duplications from devstack/upgrade/settings.

    Reference commit: 0204bd9ef4a09c791983bc1334fd32d09615ab63

    Change-Id: Ie24f97eb3dfc8355845e864aebbd5184e900da30
    Closes-Bug: #1672448

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/ocata
Review: https://review.openstack.org/481157

[OpenStack Infra (hudson-openstack)]

Fix proposed to branch: stable/newton
Review: https://review.openstack.org/481163

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481157
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=53972b61bf8f401a9c5e608ac31f025731491701
Submitter: Jenkins
Branch: stable/ocata

commit 53972b61bf8f401a9c5e608ac31f025731491701
Author: Ramamani Yeleswarapu <email address hidden>
Date: Fri Jun 30 10:22:44 2017 -0700

    [Devstack] cleanup upgrade settings

    We now enable plugin and services in project-config.
    Drop those duplications from devstack/upgrade/settings.

    Reference commit: 0204bd9ef4a09c791983bc1334fd32d09615ab63

    Change-Id: Ie24f97eb3dfc8355845e864aebbd5184e900da30
    Closes-Bug: #1672448
    (cherry picked from commit 74e27b9bf3c86642779a199f4de1f1b6ccea04d0)

[OpenStack Infra (hudson-openstack)]

Reviewed: https://review.openstack.org/481163
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=b34fa9c797fcdbbb247e574bf0dc0e4955ad5a4f
Submitter: Jenkins
Branch: stable/newton

commit b34fa9c797fcdbbb247e574bf0dc0e4955ad5a4f
Author: Ramamani Yeleswarapu <email address hidden>
Date: Fri Jun 30 10:22:44 2017 -0700

    [Devstack] cleanup upgrade settings

    We now enable plugin and services in project-config.
    Drop those duplications from devstack/upgrade/settings.

    Reference commit: 0204bd9ef4a09c791983bc1334fd32d09615ab63

    Change-Id: Ie24f97eb3dfc8355845e864aebbd5184e900da30
    Closes-Bug: #1672448
    (cherry picked from commit 74e27b9bf3c86642779a199f4de1f1b6ccea04d0)

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic-inspector 6.0.0 release.

[OpenStack Infra (hudson-openstack)]

This issue was fixed in the openstack/ironic-inspector 5.0.2 release.