missing error state transitions in the inspect code path

Bug #1662494 reported by milan k on 2017-02-07
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic Inspector
Fix Released
Medium
Anton Arefiev

Bug Description

An exception along the inspection code path[1] won't update the node state to Error.
This can lead to the FSM conducting an undefined Timeout event transition Starting -> Error.

[1] https://github.com/openstack/ironic-inspector/blob/master/ironic_inspector/introspect.py#L67,#L131

milan k (vetrisko) on 2017-02-07
Changed in ironic-inspector:
assignee: nobody → milan k (vetrisko)
milan k (vetrisko) on 2017-02-07
Changed in ironic-inspector:
assignee: milan k (vetrisko) → nobody

Fix proposed to branch: master
Review: https://review.openstack.org/430341

Changed in ironic-inspector:
assignee: nobody → Anton Arefiev (aarefiev)
status: New → In Progress
Anton Arefiev (aarefiev) on 2017-02-08
Changed in ironic-inspector:
importance: Undecided → Medium

Fix proposed to branch: master
Review: https://review.openstack.org/437377

Reviewed: https://review.openstack.org/437377
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=9f125629fe48cecc72d07a3003cac9f4aeacbd4a
Submitter: Jenkins
Branch: master

commit 9f125629fe48cecc72d07a3003cac9f4aeacbd4a
Author: Anton Arefiev <email address hidden>
Date: Wed Feb 22 18:56:44 2017 +0200

    Add new transaction starting -> error on timeout

    Exception along the `starting` inspection code may causes
    `no defined transition` error as there is no transition for
    `starting` state on timeout event.

    Also it could happen if small timeout configured, so there
    is not enough time for starting -> waiting transition,
    e.g. new greenthread spawn is blocked due to missing of
    available slots.

    Closes-Bug: #1662494
    Change-Id: I66cf0374a2ba4ab4692110daafd4a3d2d20d56d6

Changed in ironic-inspector:
status: In Progress → Fix Released

This issue was fixed in the openstack/ironic-inspector 6.0.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers