Rerunning introspection on the same node is broken: firewall is not updated

Bug #1570447 reported by Dmitry Tantsur
20
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Ironic Inspector
Fix Released
High
Dmitry Tantsur

Bug Description

It's reproduced by running introspection on only one node, waiting for the finish, then running again on the same node.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-inspector (master)

Fix proposed to branch: master
Review: https://review.openstack.org/305960

Changed in ironic-inspector:
status: Triaged → In Progress
Dmitry Tantsur (divius)
summary: - Rerunning introspection while another one is running is broken: firewall
- is not updated
+ Rerunning introspection on the same node is broken: firewall is not
+ updated
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-inspector (master)

Reviewed: https://review.openstack.org/305960
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=41580add20b20cb28dcacb5012c85a89cb46d830
Submitter: Jenkins
Branch: master

commit 41580add20b20cb28dcacb5012c85a89cb46d830
Author: Dmitry Tantsur <email address hidden>
Date: Thu Apr 14 18:02:27 2016 +0200

    Make sure to clean the blacklist cache when disabling the firewall

    Otherwise on reintrospection the firewall code may not update
    iptables rules, assuming they are already correct.

    Change-Id: Icc05174854bd9ab51bfed9d1360873bf5db9ed54
    Closes-Bug: #1570447

Changed in ironic-inspector:
status: In Progress → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-inspector (stable/mitaka)

Fix proposed to branch: stable/mitaka
Review: https://review.openstack.org/306421

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-inspector (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/306429

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-inspector (stable/liberty)

Reviewed: https://review.openstack.org/306429
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=aae6c9df876ad77863a198399b7ef595aff755d5
Submitter: Jenkins
Branch: stable/liberty

commit aae6c9df876ad77863a198399b7ef595aff755d5
Author: Dmitry Tantsur <email address hidden>
Date: Thu Apr 14 18:02:27 2016 +0200

    Make sure to clean the blacklist cache when disabling the firewall

    Otherwise on reintrospection the firewall code may not update
    iptables rules, assuming they are already correct.

    Change-Id: Icc05174854bd9ab51bfed9d1360873bf5db9ed54
    Closes-Bug: #1570447
    (cherry picked from commit 41580add20b20cb28dcacb5012c85a89cb46d830)

tags: added: in-stable-liberty
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-inspector (stable/mitaka)

Reviewed: https://review.openstack.org/306421
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=abd50d8438e7d371ce24f97d8f8f67052b562007
Submitter: Jenkins
Branch: stable/mitaka

commit abd50d8438e7d371ce24f97d8f8f67052b562007
Author: Dmitry Tantsur <email address hidden>
Date: Thu Apr 14 18:02:27 2016 +0200

    Make sure to clean the blacklist cache when disabling the firewall

    Otherwise on reintrospection the firewall code may not update
    iptables rules, assuming they are already correct.

    Change-Id: Icc05174854bd9ab51bfed9d1360873bf5db9ed54
    Closes-Bug: #1570447
    (cherry picked from commit 41580add20b20cb28dcacb5012c85a89cb46d830)

tags: added: in-stable-mitaka
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/ironic-inspector 2.2.6

This issue was fixed in the openstack/ironic-inspector 2.2.6 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/ironic-inspector 3.2.1

This issue was fixed in the openstack/ironic-inspector 3.2.1 release.

Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/ironic-inspector 3.3.0

This issue was fixed in the openstack/ironic-inspector 3.3.0 release.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers