Insufficient error message when data preprocessing failed

Bug #1523907 reported by Dmitry Tantsur
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ironic Inspector
Fix Released
High
Dmitry Tantsur

Bug Description

Not sure what I was thinking back then, but this is not a good error message:
+----------+----------------------------+
| Field | Value |
+----------+----------------------------+
| error | Data pre-processing failed |
| finished | True |
+----------+----------------------------+

Expected something like:
+----------+----------------------------------------------------------------------------------------------------------+
| Field | Value |
+----------+----------------------------------------------------------------------------------------------------------+
| error | Preprocessing hook ramdisk_error: Ramdisk reported error: The following errors were encountered: |
| | * collector logs failed: 'ascii' codec can't decode byte 0xe2 in position 241: ordinal not in range(128) |
| finished | True |
+----------+----------------------------------------------------------------------------------------------------------+

Dmitry Tantsur (divius)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-inspector (master)

Fix proposed to branch: master
Review: https://review.openstack.org/254740

Changed in ironic-inspector:
status: Triaged → In Progress
Dmitry Tantsur (divius)
tags: added: processing
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-inspector (master)

Reviewed: https://review.openstack.org/254740
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=22fddca500a1a8b1646a25fc372ba2cecf31e5b8
Submitter: Jenkins
Branch: master

commit 22fddca500a1a8b1646a25fc372ba2cecf31e5b8
Author: Dmitry Tantsur <email address hidden>
Date: Tue Dec 8 14:00:36 2015 +0100

    Properly report preprocessing errors to a user

    Currently we only return "Data pre-processing failed" and the only option
    to figure out what went wrong is to dive into logs.

    Also fixed error message for unexpected exceptions during pre-processing
    to actually contain some exception information.

    Change-Id: I998c0bbd48cc57b7b13fac220f4f7cfe2a5e0681
    Closes-Bug: #1523907

Changed in ironic-inspector:
status: In Progress → Fix Released
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/ironic-inspector 3.0.0

This issue was fixed in the openstack/ironic-inspector 3.0.0 release.

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to ironic-inspector (stable/liberty)

Fix proposed to branch: stable/liberty
Review: https://review.openstack.org/279071

Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to ironic-inspector (stable/liberty)

Reviewed: https://review.openstack.org/279071
Committed: https://git.openstack.org/cgit/openstack/ironic-inspector/commit/?id=d9044cda42be0ef5df65f298f1cb01429e21abf6
Submitter: Jenkins
Branch: stable/liberty

commit d9044cda42be0ef5df65f298f1cb01429e21abf6
Author: Dmitry Tantsur <email address hidden>
Date: Tue Dec 8 14:00:36 2015 +0100

    Properly report preprocessing errors to a user

    Currently we only return "Data pre-processing failed" and the only option
    to figure out what went wrong is to dive into logs.

    Also fixed error message for unexpected exceptions during pre-processing
    to actually contain some exception information.

    Change-Id: I998c0bbd48cc57b7b13fac220f4f7cfe2a5e0681
    Closes-Bug: #1523907
    (cherry picked from commit 22fddca500a1a8b1646a25fc372ba2cecf31e5b8)

tags: added: in-stable-liberty
Revision history for this message
Doug Hellmann (doug-hellmann) wrote : Fix included in openstack/ironic-inspector 2.2.4

This issue was fixed in the openstack/ironic-inspector 2.2.4 release.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.