IrcChannel.ModeChanged should likely bubble up mode parameters for modes like l or k

Bug #881161 reported by Jeremy Brayton on 2011-10-25
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
IRC.NET
Wishlist
Alexander Regueiro

Bug Description

The raw IRC logs on EFnet for setting and unsetting +lk in mIRC:
:w0rd-driv!~jeremy@address MODE #windowsphone +lkb 5 foobar foo!@*
:w0rd-driv!~jeremy@address MODE #windowsphone -lkb * foo!@*

http://bazaar.launchpad.net/~ircdotnet-dev/ircdotnet/0.4/view/head:/src/IrcDotNet/IrcChannel.cs#L355 and the HandleModesChanged method is where the bottleneck seemed to be as I was expecting ModeChanged to have more than the IrcUser. Comment is an available property but you'd need something else for the params array.

If you decided to store params internally, a GetModes<string>(char) could also return the param for the mode you're querying like +l or k. This starts to lay the ground work for ban lists too though so I may be stepping on the wrong side of what defines a library and client.

I suppose I could subscribe to the raw events and check that but I have time and could donate patch help if you needed it. I'm doing this for a wp7 project and I was hoping to always keep track of channel key changes in the event of disconnects, which will be frequent.

description: updated
Changed in ircdotnet:
importance: Undecided → Wishlist
status: New → Confirmed
assignee: nobody → Alex Regueiro (alexreg)
tags: added: channels
removed: ircchannel modechanged wishlist
tags: added: api irc
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers