jobctrl extension broken on non-windows platforms

Bug #237222 reported by Fernando Perez
2
Affects Status Importance Assigned to Milestone
IPython
Fix Released
Medium
Ville M. Vainio

Bug Description

Bug reported originally by Tony Mannucci on list. Here's how to reproduce it:

In [1]: ls *.zip
wrapping.zip

In [2]: import jobctrl

In [3]: ls *.zip
---------------------------------------------------------------------------
NameError Traceback (most recent call last)

/home/fperez/tmp/<ipython console> in <module>()

/home/fperez/usr/lib/python2.5/site-packages/IPython/iplib.pyc in <lambda>(cmd)
    496 # and it allows interpolation of variables in the user's namespace.
    497 self.system = lambda cmd: \
--> 498 self.hooks.shell_hook(self.var_expand(cmd,depth=2))
    499
    500 # These are for getoutput and getoutputerror:

/home/fperez/usr/lib/python2.5/site-packages/IPython/hooks.pyc in __call__(self, *args, **kw)
    133 #print "prio",prio,"cmd",cmd #dbg
    134 try:
--> 135 ret = cmd(*args, **kw)
    136 return ret
    137 except ipapi.TryNext, exc:

/home/fperez/usr/lib/python2.5/site-packages/IPython/Extensions/jobctrl.pyc in jobctrl_shellcmd(ip, cmd)
    209 try:
    210 p = Popen(cmd,shell = use_shell)
--> 211 except WindowsError:
    212 if use_shell:
    213 # try with os.system

NameError: global name 'WindowsError' is not defined

Changed in ipython:
importance: Undecided → Medium
status: New → Confirmed
Changed in ipython:
assignee: nobody → villemvainio
status: Confirmed → Fix Committed
Changed in ipython:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.