race in intltool-merge .desktop file generation

Bug #1687644 reported by Bernhard M. Wiedemann
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
intltool
Fix Committed
High
Bernhard M. Wiedemann

Bug Description

When building software by running make -jNUMBER
it can happen that multiple intltool-merge processes are run in parallel.
In such cases we observed .desktop files being produced with a few random missing translations.

This is, because the first intltool-merge process creates a cache file
and the second intltool-merge process uses the cache file
even before the first one is done writing it.

Please apply the attached patch

Related branches

Revision history for this message
Bernhard M. Wiedemann (ubuntubmw) wrote :
Changed in intltool:
status: New → Triaged
importance: Undecided → High
Revision history for this message
Данило Шеган (danilo) wrote :

Please make a merge proposal:

 - start by branching from lp:intltool using "bzr branch lp:intltool"
 - "cd intltool" and apply your patch
 - "bzr push lp:~ubuntubmw/intltool/fix-cache-race"
 - Browse to your code page (https://code.launchpad.net/~ubuntubmw), select the newly uploaded branch and make a merge proposal explaining the change

I'll take a look later and if I see no problems with it (looks good from a quick glance), I'll merge it.

Revision history for this message
Bernhard M. Wiedemann (ubuntubmw) wrote :
Changed in intltool:
status: Triaged → Fix Committed
assignee: nobody → Bernhard M. Wiedemann (ubuntubmw)
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers