Comment 19 for bug 992124

su_v (suv-lp) wrote :

@Samuel - I'm not able to really help with questions about clang, neither on ArchLinux (or other Linux distros) nor on OS X, sorry. Same with regard to questions about memory leaks (but if your patch creates some, please fix it ;-) ).

With regard to the first patch for files in 'src/2geom': maybe you can address the compiler warnings, too? They occur with old and newer GCC versions, as well as with Clang:

../../src/2geom/basic-intersection.cpp:70:23: warning: comparison of integers of different signs: 'int' and 'const unsigned int' [-Wsign-compare]
    for (int i = 0; i < sz; ++i) {
                    ~ ^ ~~

../../src/2geom/recursive-bezier-intersection.cpp:87:23: warning: comparison of integers of different signs: 'int' and 'const unsigned int' [-Wsign-compare]
    for (int i = 0; i < sz; ++i) {
                    ~ ^ ~~

../../src/2geom/solve-bezier-parametric.cpp:201:23: warning: comparison of integers of different signs: 'int' and 'unsigned int' [-Wsign-compare]
    for (int i = 0; i < degree + 1; ++i) {
                    ~ ^ ~~~~~~~