changes in r11261 affect wrapping of color palette if run from gdb

[su_v]

Current debug builds >= r11261 (llvm-gcc-4.2, OS X 10.7.2 (64bit)), if run from gdb, no longer display the palette as a single row of color swatches with a horizontal scroll bar beneath, but instead fully wrap the long row, causing the color palette to have a huge height (default preferences).
Changing the palette layout (toggling 'Wrap' on and off) does not restore the normal behavior.

Probably related compiler warning if built with FSF GCC 4.6.3:
  CXX ui/previewholder.o
../../src/ui/previewholder.cpp: In member function 'void Inkscape::UI::PreviewHolder::calcGridSize(const Gtk::Widget*, int, int&, int&)':
../../src/ui/previewholder.cpp:272:99: warning: 'req2._GtkRequisition::height' may be used uninitialized in this function [-Wuninitialized]
../../src/ui/previewholder.cpp:273:94: warning: 'req2._GtkRequisition::width' may be used uninitialized in this function [-Wuninitialized]

Possibly caused by a typo (copy&paste (?)) in revision 11261: with attached patch, the palette displays again as expected if launched from gdb.

[su_v (suv-lp)]

Screenshot comparing r11270:
- left: unpatched
- right: patched

(OS X 10.7.2, 64bit, llvm-gcc-4.2, '-g -O0', run from gdb, default prefs)

[su_v (suv-lp)]

However - without or with the proposed patch to fix a typo, wrapping of the palette seems to be broken after revision 11261 (tested without gdb).

[su_v (suv-lp)]

Screenshot comparing r11260 and r11261 (OS X 10.7.2, 64bit), run directly (without gdb):
- stock gtk theme
- default preferences, with palette settings changed to
   -> Size > Tiny
   -> Width > Narrower
   -> Wrap

[Alex Valavanis (valavanisalex)]

Should be fixed in lp:inkscape r11274. Sorry about that!

[su_v (suv-lp)]

> New → Fix Released

As mentioned in comment #3 (and shown in screenshot of comment #4), something else got broken in revision r11261 with regard to the palette: without or with my proposed patch for the one typo, 'wrap' no longer really wraps, but simply repeats the colors of the first line below, making it a useless layout option. Works as expected in r11260 (the layout options are at the top of the menu to change the palette currently displayed).

Do you want me to file a separate report about it? (still present in r11275)

[su_v (suv-lp)]

> As mentioned in comment #3 (…)

I do get slightly inconsistent results: with the latest round of builds (r11275) on 2 systems with 3 different compilers (and slightly different versions of the dependencies), I have two builds which wrap the palette correctly
- OS X 10.7.2 (64bit), Apple llvm-gcc-4.2
  Gtk+/X11 2.24.10, glib 2.32.1, glibmm 2.32.0
- OS X 10.7.2 (64bit), Apple llvm-gcc-4.2
  Gtk+/Quartz 2.24.10 (+patches from git), glib 2.32.1, glibmm 2.32.0

The other ones don't really wrap the color swatches, but repeat the first row several times (as shown on the screenshot in comment #4):
- OS X 10.7.2 (42bit), FSF GCC 4.6.3
  Gtk+/X11 2.24.10, glib 2.32.1, glibmm 2.32.0
- OS X 10.5.8 (32bit), Apple GCC 4.2
  Gtk+/X11 2.24.8, glib 2.28.8, glibmm 2.28.0
- OS X 10.5.8 (32bit), Apple GCC 4.2
  Gtk+/Quartz 2.24.10, glib 2.28.10, glibmm 2.28.2

It doesn't matter which gtk theme is used (without user and system gtkrc, or with custom settings).

[su_v (suv-lp)]

typo:
- - OS X 10.7.2 (42bit), FSF GCC 4.6.3
+ - OS X 10.7.2 (64bit), FSF GCC 4.6.3

[Alex Valavanis (valavanisalex)]

Oops... sorry, I didn't check it properly. No need for a separate report... I'll look into this tomorrow, hopefully.

[Alex Valavanis (valavanisalex)]

Should be fixed in lp:inkscape r11301. Sorry about that!

[su_v (suv-lp)]

> Should be fixed in lp:inkscape r11301. Sorry about that!

@Alex - no problem :-) - palette looks fine now in r11301 in all test builds.