Gcodetools: Unlocalized messages

Bug #980527 reported by Masato HASHIMOTO on 2012-04-13
This bug affects 3 people
Affects Status Importance Assigned to Milestone
Fix Committed

Bug Description

The following messages in Gcodetools-About/Help are translatable but localized messages are not shown.

#: ../share/extensions/gcodetools_about.inx.h:2
msgid ""
"Gcodetools was developed to make simple Gcode from Inkscape's paths. Gcode "
"is a special format which is used in most of CNC machines. So Gcodetools "
"allows you to use Inkscape as CAM program. It can be use with a lot of "
"machine types: Mills Lathes Laser and Plasma cutters and engravers Mill "
"engravers Plotters etc. To get more info visit developers page at http://www."

#: ../share/extensions/gcodetools_about.inx.h:4
msgid ""
"Gcodetools plug-in: converts paths to Gcode (using circular interpolation), "
"makes offset paths and engraves sharp corners using cone cutters. This plug-"
"in calculates Gcode for paths using circular interpolation or linear motion "
"when needed. Tutorials, manuals and support can be found at English support "
"forum: http://www.cnc-club.ru/gcodetools and Russian support forum: http://"
"www.cnc-club.ru/gcodetoolsru Credits: Nick Drobchenko, Vladimir Kalyaev, "
"John Brooker, Henry Nicolas, Chris Lusby Taylor. Gcodetools ver. 1.7"

Version: trunk-r11233

jazzynico (jazzynico) wrote :

Adding the xml:space="preserve" attribute should fix the issue.
I'll take a closer look later today.

Changed in inkscape:
assignee: nobody → JazzyNico (jazzynico)
importance: Undecided → Low
status: New → Triaged
tags: added: extensions translation
jazzynico (jazzynico) wrote :

xml:space="preserve" fix confirmed.

@Nick - Since the inx files are created from a global inx file (gcodetools-dev.inx in the gcodetools trunk), it would be easier to wait until it is fix upstreams than replacing each inx files in Inkscape. Could you please tell us if you plan to release a new gcodetools version soon?
By the way, the Inkscape extension is tagged 1.7, and the trunk 1.6. I guess it's just you forgot to update it ;)

Changed in inkscape:
status: Triaged → In Progress
jazzynico (jazzynico) wrote :

Patch attached, based on gcodetool revision 228.

Nick (xepecine) wrote :

Just waiting to finish some new features to make new release, 1.7 is still -dev version.
If it is in hurry we can try to speed up the development a little bit :)

I'll add this xml:space="preserve" to the gcodetools branch.
I can patch the files in inkscape trunk if it's needed...

jazzynico (jazzynico) wrote :

There's no hurry, and we can wait until 1.7 is out.

Changed in gcodetools:
assignee: nobody → Nick (xepecine)
status: New → Fix Committed
Kris (kris-degussem) wrote :

See also Bug #731177 . Probably worth treating this one simultaneously.

jazzynico (jazzynico) on 2012-05-09
Changed in inkscape:
assignee: JazzyNico (jazzynico) → Nick (xepecine)
su_v (suv-lp) on 2013-01-06
tags: added: extensions-plugins
removed: extensions
jazzynico (jazzynico) wrote :

Patch applied to the upstream code, but not ported to Inkscape yet.

Changed in inkscape:
assignee: Nick (xepecine) → jazzynico (jazzynico)
milestone: none → 0.93
jazzynico (jazzynico) wrote :

Patch for 0.92.x (probably works for the trunk too).

jazzynico (jazzynico) wrote :

Fixed in lp:inkscape rev. 15543.

Changed in inkscape:
status: In Progress → Fix Committed
jazzynico (jazzynico) wrote :

Fixed in lp:inkscape/0.92.x rev. 15394.

Patrick Storz (ede123) wrote :

Is this something we could/should fix?

I didn't look into it, but I assume it's simply not working because whitespace is trimmed (probably inside the extension implementation) but not by intltool to create the .pot file?

jazzynico (jazzynico) wrote :

Yes, we need to fix the INX files so that multi-lines descriptions always have the white-space=preserve attribute.
It's documented on our wiki: http://wiki.inkscape.org/wiki/index.php/INX_Parameters#Available_types

Patrick Storz (ede123) wrote :

I meant fixing multiline "description"s in Inkscape code to be translatable even if xml:space="preserve" is *not* used.

Setting xml:space="preserve" basically forces add-on authors to pre-format the description.
Often it might be desirable to use line breaks / indentation in .inx files to keep the source readable (without it influencing text formatting). This should however not break translations...

jazzynico (jazzynico) wrote :

Well, yes, we could probably fix the case where the newlines are used for source formating only (by testing the presence of the "preserve" value). But I'm not sure it's worth the effort.

Patrick Storz (ede123) wrote :

Follow-up for the underlying issue in bug #1668115.
There's a question whether we should change behavior of how "description"s are rendered when xml:space="preserve" is not used, so let me know what you think.

Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers