Permissions and #! in extension scripts need fixing

Bug #887539 reported by Alex Valavanis
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
jazzynico

Bug Description

Lintian is spotting a few issues with inkscape trunk. Numerous python extension scripts are being installed as executables, but do not contain #! markers, meaning that they can be directly executed by the user but the system will try to run them as sh scripts and will fail.

We've had a similar issue to this previously. We should add #! markers to everything that is supposed to be directly executable. Everything else should be changed from "extension_SCRIPTS" to "module_DATA". Even better, I guess we should use a _PYTHON automake rule to ensure that the modules are byte-compiled.

W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/RM4CC.py
N:
N: This executable file is not an ELF format binary, and does not start
N: with the #! sequence that marks interpreted scripts. It might be a sh
N: script that fails to name /bin/sh as its shell, or it may be incorrectly
N: marked as executable. Sometimes upstream files developed on Windows are
N: marked unnecessarily as executable on other systems.
N:
N: If you are using debhelper to build your package, running dh_fixperms
N: will often correct this problem for you.
N:
N: Refer to Debian Policy Manual section 10.4 (Scripts) for details.
N:
N: Severity: normal, Certainty: certain
N:
N: Check: scripts, Type: binary
N:
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/Code39.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/__init__.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/Code39Ext.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/EAN8.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/EAN13.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/Base.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/previous_glyph_layer.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/UPCA.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/svg_regex.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/EAN5.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/setup_typography_canvas.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/svgfont2layers.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/Code93.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/render_barcode_qrcode.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/layers2svgfont.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/Code128.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/Code25i.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/next_glyph_layer.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/BaseEan.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/new_glyph_layer.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/Barcode/UPCE.py
W: inkscape-trunk: executable-not-elf-or-script usr/share/inkscape/extensions/layout_nup_pageframe.py

tags: added: build extensions-plugins
su_v (suv-lp)
tags: added: linux
Revision history for this message
su_v (suv-lp) wrote :

[ Follow-up report to bug #602005 ]

Changed in inkscape:
importance: Undecided → Low
status: New → Triaged
jazzynico (jazzynico)
Changed in inkscape:
assignee: nobody → JazzyNico (jazzynico)
milestone: none → 0.48.3
Revision history for this message
jazzynico (jazzynico) wrote :

Fix committed in the trunk, revision 10747.
Branch changes in progress.

Changed in inkscape:
status: Triaged → In Progress
Revision history for this message
jazzynico (jazzynico) wrote :

Fix committed in the branch (barcode stuff only), revision 9838.

Changed in inkscape:
status: In Progress → Fix Committed
Ted Gould (ted)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.