c++11 build fixes
Bug #858814 reported by
Pippijn van Steenhoven
This bug affects 2 people
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Inkscape |
Fix Released
|
Medium
|
Pippijn van Steenhoven |
Bug Description
Some semantics changed in the new C++ standard. In one case, a GCC extension is now in the standard, but using a different syntax. In the attached patch, I fixed them in a quick (and in some cases dirty) fashion. You may choose to fix them in a different way. In at least one case, I would suggest another way, but it would have taken another half rebuild. This patch should apply to trunk, cleanly.
To get a failing build, I used GCC 4.6 (it probably fails with 4.5 and 4.4 and maybe 4.3) in C++0x mode (-std=c++0x).
Related branches
tags: | added: build |
description: | updated |
Changed in inkscape: | |
importance: | Undecided → Wishlist |
Changed in inkscape: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.
Thanks for your patch, and sorry it has taken so long to review!
I've made a couple of updates so that it applies cleanly to trunk and uses the __cplusplus macro to test C++ standard (the macro is part of the C++ standard rather than a GCC thing).
Committed in lp:inkscape r12166.