send dbus signal when object moves

[[e-mail]]

There is a proposal in the DBus extension to send a dbus signal when
an object is moved in Inkscape.

I made a first attempt to implement this in my dbus branch.

This works atm:

- Dragging an object with the mouse. When the mouse button is released
a signal with the object id is sent.

- the event was verified to arrive in a subscribed Dbus listener,
  Emacs.

This doesn't work:

- sending from more than 1 window. (Because I made a sloppy global
  variable hack to test)

- sending a signal when the object moves by any other means than
  dragging. (because I haven't found the right place to send the
  signal yet)

Anyway, I'm pleased, and I think signals will open up interesting
posibilities. My use-case is interactive round-trip graph editing.

[su_v (suv-lp)]

The dbus branch (r10032, AFAICT) was merged into trunk in r10559.

Are the debug messages ("moved!", "Ping!") from the merged branch still required/useful in trunk, or could they be commented out in trunk, or made depend on a configure variable (for debugging purposes)?

(Attached diff comments them out)

@joakim - can this and the other two open feature requests linked to your branch be closed as 'Fix Committed'?
    * Bug #793412: view area control via dbus
    * Bug #795014: dbus get_parent and get_children

[[e-mail] (joakim-verona)]

~suv <email address hidden> writes:

> The dbus branch (r10032, AFAICT) was merged into trunk in r10559.
>
> Are the debug messages ("moved!", "Ping!") from the merged branch still
> required/useful in trunk, or could they be commented out in trunk, or
> made depend on a configure variable (for debugging purposes)?
>
> (Attached diff comments them out)
>
> @joakim - can this and the other two open feature requests linked to your branch be closed as 'Fix Committed'?
> * Bug #793412: view area control via dbus
> * Bug #795014: dbus get_parent and get_children
>
>
> ** Branch linked: lp:~joakim-verona/inkscape/dbus-fixes
>
> ** Patch added: "739453-turn-off-dbus-debug-messages.diff"
> https://bugs.launchpad.net/inkscape/+bug/794295/+attachment/2333776/+files/739453-turn-off-dbus-debug-messages.diff

Yes, remove the traces, and bugs can be closed.

If I could get committ access to trunk I could fix such embarrassing
misstakes myself. I think I'm eligible now since I had a number of
patches accepted.

--
Joakim Verona

[jazzynico (jazzynico)]

> I think I'm eligible now since I had a number of patches accepted.

Welcome to the Inkscape Developers team!

[su_v (suv-lp)]

Merged into lp:inkscape at revision 10559

[su_v (suv-lp)]

The debug statements have been removed by Felipe in r10640:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/10640>

> This doesn't work:
>
> - sending from more than 1 window. (Because I made a sloppy global
> variable hack to test)

When editing a second document opened from within Inkscape, these console warnings appear whenever moving an object:
 (inkscape:791): GLib-GObject-WARNING **: invalid (NULL) pointer instance
 (inkscape:791): GLib-GObject-CRITICAL **: g_signal_emit_valist: assertion `G_TYPE_CHECK_INSTANCE (instance)' failed

[su_v (suv-lp)]

@joakim - any chance you could take a closer look whether your changes to implement the 'moved' signal triggers
 Bug #833878 “randomly crashes (possibly dbus related)”
 <https://bugs.launchpad.net/inkscape/+bug/833878>

Dragging an object with the mouse while having a modifier key pressed ('Ctrl' or 'Alt') consistently crashes Inkscape if built with the dbusapi enabled. This is highly annoying when using the GUI to modify drawings (even though I try hard to adapt my workflow for now, I get several crashes a day due to the bug).