Use expression evaluator for spinboxes of the 'Tiled Clones' dialog

Bug #773636 reported by su_v on 2011-04-29
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Wishlist
Codain

Bug Description

Follow-up report to Bug #171282 “Calculator in input fields”

The spinboxes in the 'Tiled Clones' dialog of current trunk (tested with r10191) do not yet support the new expression evaluator.
It would also great if the input precision could be raised at the same time (see bug #171980).

Tags: ui Edit Tag help
jazzynico (jazzynico) on 2011-05-04
Changed in inkscape:
status: New → Triaged
Codain (codain) wrote :

I've successfully started working on it based on current trunk.

Changed in inkscape:
assignee: nobody → Romain (romain2boss)
status: Triaged → In Progress
Codain (codain) wrote :

Here is my patch.

I've replaced all GtkSpinButton by Inkscape::UI::Widget::SpinButton and, when possible, related GtkAdjustment in Gtk::Adjustment.

There is still some GTK C code related to those widgets when I could not C++ified (especially for signals).

I've tried and compare the patch between my patched Inkscape and 0.48.2 and have seen no difference. Values are well stored, loaded and reseted when needed.

ScislaC (scislac) wrote :

Romain, have you had any patches accepted yet? I plan to review and test this in the next couple days, but once you've had 2 accepted patches you get commit access, and given your interest I don't think we want to impede you. :)

Codain (codain) wrote :

I've submited two patches: this one and one to enable pasting colors whithout '#' in the color notebook (but it was not perfect, JazzyNico had to do a modification).

jazzynico (jazzynico) wrote :

Patch tested on Ubuntu 11.04, Inkscape revision 10878.
Works as expected, no regression found.

@~suv - Could you please test on OSX before I commit?

Changed in inkscape:
milestone: none → 0.49
su_v (suv-lp) wrote :

Patch tested with Inkscape 0.48+devel r10877 on:
- Mac OS X 10.5.8 (32bit) with Gtk+/Quartz 2.24.8, glib 2.28.8
- OS X 10.7.2 (64bit) with Gtk+/X11 2.24.8, glib 2.30.2

AFAICT works as expected, no regression found.

jazzynico (jazzynico) wrote :

Patch committed, trunk revision 10879.
Thanks, Romain!

Changed in inkscape:
status: In Progress → Fix Committed
Bryce Harrington (bryce) on 2015-02-23
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers