"border on top" and "border shadow" options are still active when "show border" is disabled

Bug #773288 reported by Shish on 2011-04-29
This bug affects 1 person
Affects Status Importance Assigned to Milestone
inkscape (Ubuntu)

Bug Description

Binary package hint: inkscape

In document properties -> border; I would expect "border on top" and "border shadow" to be indented slightly, as sub-options of "show border", and to be greyed out when "show border" is disabled (unless I'm missing something, and they do have an effect even with the border turned off...)

ProblemType: Bug
DistroRelease: Ubuntu 11.04
Package: inkscape 0.48.1-2ubuntu2
ProcVersionSignature: Ubuntu 2.6.38-8.42-generic
Uname: Linux 2.6.38-8-generic x86_64
NonfreeKernelModules: nvidia
Architecture: amd64
Date: Fri Apr 29 15:18:22 2011
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 10.10 "Maverick Meerkat" - Release amd64 (20101007)
 PATH=(custom, user)
SourcePackage: inkscape
UpgradeStatus: No upgrade log present (probably fresh install)

Shish (shish) wrote :
Changed in inkscape (Ubuntu):
importance: Undecided → Low
status: New → Triaged
tags: added: ui
su_v (suv-lp) on 2011-04-29
Changed in inkscape:
importance: Undecided → Low
status: New → Triaged
demicoder (moduli16) on 2012-09-27
Changed in inkscape:
status: Triaged → Confirmed
Changed in inkscape (Ubuntu):
status: Triaged → Confirmed

The attachment "773288-disable-page-border-options.diff" of this bug report has been identified as being a patch. The ubuntu-reviewers team has been subscribed to the bug report so that they can review the patch. In the event that this is in fact not a patch you can resolve this situation by removing the tag 'patch' from the bug report and editing the attachment so that it is not flagged as a patch. Additionally, if you are member of the ubuntu-reviewers team please also unsubscribe the team from this bug report.

[This is an automated message performed by a Launchpad user owned by Brian Murray. Please contact him regarding any issues with the action taken in this bug report.]

tags: added: patch
su_v (suv-lp) wrote :

Testing patch with r11709 on OS X 10.7.4 with GTK+/X11 2.24.10 and GTK+/Quartz 2.24.13:

The logic to detect settings from existing documents seems wrong:
- 'Show border shadow' is not checked ([x]) even if the document shows page border shadows.
- 'Show border shadow' is insensitive if it had been turned off for the document, and the visibility of the page borders itself needs to be toggled off/on again to enable (make sensitive) the page border shadow option

Probably 'Border on top of drawing' has the same reversed logic (I didn't have old test files at hand which would have allowed to quickly compare the display of the borders with the detected settings in 'Document Properties'.

demicoder (moduli16) wrote :

Patch to the bug.

su_v (suv-lp) on 2012-09-27
Changed in inkscape:
assignee: nobody → demicoder (moduli16)
status: Confirmed → In Progress
su_v (suv-lp) wrote :

The latest patch added (after my earlier comment) is identical from the one attached earlier (and still seems to have broken logic reading settings from the current document). It would be helpful if you could add version tags to patches you attach in the future (e.g. 773288-disable-page-border-options-new-v1.diff, 773288-disable-page-border-options-new-v2.diff, etc.).

su_v (suv-lp) wrote :

Attaching a screenshot to illustrate the first point described in comment #6:
- A new default document, which renders the page border as well as shows the page border shadow.
- 'Document properties > Page > Border' settings which has '[ ] Show border shadow' not checked, despite it being shown.
To me this is inconsistent (I expect the page properties to always reflect the current state of the document).

su_v (suv-lp) wrote :

Attaching a screenshot to illustrate the second item described in comment #6:
- A custom document created and saved with unpatched Inkscape: renders page border, but no border shadow
- 'Document properties > Page > Border' has '[ ] Show border shadow' insensitive (i.e. cannot be changed)
To me this is inconsistent: if 'Show page border' is active, I see no reason why toggling the border shadow on again should be not allowed anymore.

su_v (suv-lp) wrote :
su_v (suv-lp) wrote :

To clarify - detailed steps taken for the screenshots:
first one:
1) launch inkscape with default preferences
   (opens a new document based on default template)
2) open 'File > Document Properties'
3) take screenshot

second one:
1) launch inkscape with default preferences
2) open existing file via 'File > Open'
2) open 'File > Properties'
3) take screenshot

No changed had been done to the page border settings in the current session before the screenshots were made.

demicoder (moduli16) wrote :

Patch to the bug.

demicoder (moduli16) wrote :

Final bug patch.
Goals achieved:
1.) 'Border On Top' and 'Show Page Border' are grayed out when 'Show Page Border' is unchecked.
2.) 'Border On Top' and 'Show Page Border' are indented right just enough to give an intuitive feel that these are suboptions of 'Show Border'.

su_v (suv-lp) wrote :

Patch '7773288-disable-page-border-options_Version4.diff' tested successfully with Inkscape 0.48+devel r11829 on OS X 10.7.4:
- GTK+/X11 2.24.13, gtkmm 2.24.2
- GTK+/Quartz 2.24.13, gtkmm 2.24.2
- GTK+/X11 3.4.4, gtkmm 3.4.0
- GTK+/Quartz 3.6.1, gtkmm 3.6.0

(Note: Default Gnome theme 'Adwaita' for GTK2 (gnome-themes-standard 3.4.4, 3.6.1) has a known bug not showing the 'activated' checkbox state of insensitive options [1], other GTK2 themes are not affected AFAICT).

@JazzyNico - any chance you could test the patch with your builds? From my POV the latest version is ready to be committed …

[1] <https://bugzilla.redhat.com/show_bug.cgi?id=856194#c32>

jazzynico (jazzynico) wrote :

Tested successfully on Ubuntu 11.04, Inkscape trunk revision 11829.

Just a note on the coding style: the patch doesn't follow the coding recommendations (see http://inkscape.org/doc/coding_style.php), and shows braces and indentation issues. Would you be willing to fix it?

jazzynico (jazzynico) wrote :

Fix committed revision 11863.
The whole function (and not only your changes, that after all were quite consistent with the rest) needed some coding style changes to improve readability.

demicoder, thanks for your patch!

Changed in inkscape:
milestone: none → 0.49
status: In Progress → Fix Committed
tags: added: patch-accepted-upstream
removed: patch
Changed in inkscape (Ubuntu):
status: Confirmed → Triaged
Changed in inkscape:
status: Fix Committed → Fix Released
Changed in inkscape (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.