KEY MAPPING: Comma and period hijacked by scaling

Bug #770681 reported by Troy James Sobotka on 2011-04-26
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Low
Sandra Snan

Bug Description

Summary: It seems the comma and period keys are hijacked by scaling despite overriding with default.xml in ~/config/inkscape/keys. The xara.xml keyboard mapping confirms this with a #FIXME comment.

Version: bzr 10192

Platform: Linux amd64 (Ubuntu 11.04)

Related branches

jazzynico (jazzynico) on 2011-04-26
tags: added: shortcuts
removed: comma keyboard mapping period
Changed in inkscape:
importance: Undecided → Low
Sandra Snan (sandra-snan) wrote :

I’ve created a branch that fixes this, but it doesn’t use gobble_key_events any more which might be a problem. I wasn’t sure yet how to make the &event available outside of select-context.cpp.

su_v (suv-lp) wrote :

Diff from branch tested with r10860 (default new preferences) on
- OS X 10.7.2 Lion (llvm-gcc-4.2, gtk2/x11 2.24.8, glib 2.30.2),
  optimized build (-O3), debug build (-g -O0)
- Mac OS X 10.5.8 Leopard (gcc-4.2, gtk2/x11 2.24.4, glib2 2.28.8)
  optimized build (-O3)

All three builds start with these console warnings:

 (inkscape:13660): Gtk-WARNING **: SelectionGroup: missing action SelectionGroup

 (inkscape:13660): Gtk-WARNING **: SelectionUnGroup: missing action SelectionUnGroup

and have an incomplete command bar (missing icons: starting with group/ungroup up to and including document properties).
Adding placeholder icons into '$PREFIX/share/inkscape/icons/icons.svg' referenced in 'src/verbs.cpp' does not change this, nor replacing the icon references in 'src/verbs.cpp' with 'NULL'.

su_v (suv-lp) wrote :

Forgot to mention: AFAICT the new verbs themselves (in the select tool context) work the same as the prior hard-coded shortcuts.

Sandra Snan (sandra-snan) wrote :

I got the same "missing action SelectionGroup" so I moved place where the new verbs where defined in verbs.cpp to match verbs.h.

I didn’t see any missing icons because I had the command bar not visible :/
and now after my change, all icons seems to be there.
Still, when I start up I get:

(inkscape:4197): Gtk-WARNING **: Could not find the icon 'object-visible'. The 'hicolor' theme
was not found either, perhaps you need to install it.

su_v (suv-lp) wrote :

The other warning is harmless - you apparently have none of the Gtk+ icon themes properly installed, not even the stock one?
(It's odd though AFAIU to occur on a linux platform; well known OTOH from Windows and OS X ports which bundle the Gtk+ libs for Inkscape).

Sandra Snan (sandra-snan) wrote :

I built in a sid chroot which has apt-get build-dep inkscape and almost nothing else.

su_v (suv-lp) wrote :

No more warnings and missing icons on the command bar with Inkscape 0.48+devel r10865 + updated diff (based on r10862 of the branch) on OS X Lion (debug build).

@JazzyNico - any chance you could test on Windows?

jazzynico (jazzynico) wrote :

Tested on Windows XP, Inkscape 10865.
Works as expected, except the < and > keys which are now ineffective.

What's the point in adding new icons in the icon file? Apparently they are not used at all in the menus or tool bars.

Sandra Snan (sandra-snan) wrote :

The < and > can easily be added in inkscape.xml shortcut file.
OTOH, I’ve got some unrelated second thoughts about this branch o’ mine. It’s messy.

jazzynico (jazzynico) wrote :

Ouch! It seems we completely forgot that report.
JFTR, the modified code is now in src/ui/tools/select-tool/cpp.

Changed in inkscape:
status: New → In Progress
jazzynico (jazzynico) on 2016-04-06
Changed in inkscape:
assignee: nobody → jazzynico (jazzynico)
jazzynico (jazzynico) on 2016-05-25
Changed in inkscape:
milestone: none → 0.92
jazzynico (jazzynico) wrote :

Patch updated and tested on Xubuntu 16.04, Inkscape trunk rev. 14917.

Note that the branch (and thus the report) status is unclear to me. The change is useful for users that can't access the comma, period, greater or less keys without modifier, but Sandra seemed to have doubts on her code, and Martin rejected the branch. Could anyone clarify? Thanks.

jazzynico (jazzynico) wrote :

Martin, I recently updated the patch. Could you please give details on why you rejected the original merge proposal? Would the new patch be acceptable?

jazzynico (jazzynico) wrote :

Considering the low importance of the bug and the fact that 0.92 is about to be released, I'm setting the milestone to 0.93 (and commit it soon to the trunk so that we have time to test it extensively).

Changed in inkscape:
milestone: 0.92 → 0.93
jazzynico (jazzynico) wrote :

Patch applied in lp:inkscape rev. 15155.

Changed in inkscape:
assignee: jazzynico (jazzynico) → Sandra Snan (sandra-snan)
status: In Progress → Fix Committed
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers