Color Picker/Dropper: Color selection area not lined up with target in cursor

Bug #758718 reported by Šimánek
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
Mc

Bug Description

When I use the color picker/dropper to choose a color, the selected color seems to be coming from the tip of the "dropper" in the dropper cursor rather than the "target" of the cursor. I'm seeing this in .48 on Ubuntu 10.10

Revision history for this message
jazzynico (jazzynico) wrote :

Confirmed on Windows XP, Inkscape trunk revision 10145.
The selection target is shifted 3 pixels to the bottom-right of the cursor image.

Changed in inkscape:
importance: Undecided → Low
status: New → Triaged
tags: added: dropper ui
su_v (suv-lp)
tags: added: easy-fix
Avik Pal (avikpal-me)
Changed in inkscape:
assignee: nobody → Avik Pal (avikpal-me)
Avik Pal (avikpal-me)
Changed in inkscape:
assignee: Avik Pal (avikpal-me) → nobody
Revision history for this message
Mc (mc...) wrote :

should fix the problem with(5,5) instead of (7,7)
(compiled, tested)

(i looked at the cursor xpm to find the coords, assuming it starts at 0,0)

Revision history for this message
Mc (mc...) wrote :

oops, forgot to check the change with stroke dropper .

Revision history for this message
jazzynico (jazzynico) wrote :

Patch tested successfully on Windows XP, Inkscape trunk revision 13828.
Thanks, Mc!

Changed in inkscape:
assignee: nobody → Mc (mc...)
milestone: none → 0.92
status: Triaged → In Progress
tags: added: backport-proposed
Revision history for this message
jazzynico (jazzynico) wrote :

Also tested on Crunchbang Waldorf, and committed in the trunk revision 13829.
Thanks!

Changed in inkscape:
status: In Progress → Fix Committed
Revision history for this message
ScislaC (scislac) wrote :

Backported fix in 0.91.x r13700.

Changed in inkscape:
milestone: 0.92 → 0.91
su_v (suv-lp)
tags: removed: backport-proposed
Bryce Harrington (bryce)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.