Inkscape: A Vector Drawing Tool

Typos and untranslatable messages in Gcodetools

Reported by Yuri Chornoivan on 2011-03-08
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Gcodetools
Fix Committed
Undecided
Nick
Inkscape
Low
Nick

Bug Description

Gcodetools plugin in Inkscape bzr contains several typos in messages and untranslatable messages:

Typos:
sould->should
dont->don't
artefact->artifact

Untanslatable messages:
See the patch attached.

~suv (suv-lp) on 2011-03-08
tags: added: extensions-plugins translation
removed: gcodetools patch typo
jazzynico (jazzynico) wrote :

@Nick - Could you please take a look and apply the patch upstream?
There's another i18n patch waiting in Bug #654528, could you please apply it as well?
Thanks!

Changed in inkscape:
assignee: nobody → Nick (xepecine)
importance: Undecided → Low
status: New → Triaged
Nick (xepecine) wrote :

I've applied the patches to Gcodetools v1.7dev which will be released as a stable in a month.

Thanks for the report!

jazzynico (jazzynico) wrote :

Thanks Nick!
Just tell us when it's ready so that we commit it in Inkscape.

Changed in inkscape:
status: Triaged → In Progress
Yuri Chornoivan (yurchor-gmail) wrote :

Oops... Seems that underscores in gcodetools-dev.inx are missing:

235
                        <_option value="Move path">Move path</option>

236
                        <_option value="Offset path">Offset path</option>

http://bazaar.launchpad.net/~gcodetools.team/gcodetools/develope/revision/181

Should it be

235
                        <_option value="Move path">Move path</_option>

236
                        <_option value="Offset path">Offset path</_option>

?

Thanks in advance for your answer.

Nick (xepecine) wrote :

fixxed that.

Thanks.

jazzynico (jazzynico) wrote :

> Oops... Seems that underscores in gcodetools-dev.inx are missing

Confirmed. Underscores should also be present in ending tags.

jazzynico (jazzynico) wrote :

Gcodetools rev. 183 looks good.
Do you plan some more changes in the near future, or can I commit this revision in the Inkscape trunk?

Changed in gcodetools:
assignee: nobody → Nick (xepecine)
status: New → Fix Committed
Changed in inkscape:
assignee: Nick (xepecine) → JazzyNico (jazzynico)
status: In Progress → Triaged
Nick (xepecine) wrote :

Probably you can commit it.
I've planned to make a release in a month, and left this month for bugfixing.

But if we are in hurry then you can commit this revision...

How do you think when the new version of Inkscape will be released?

jazzynico (jazzynico) wrote :

Nick> How do you think when the new version of Inkscape will be released?

0.49 release date is not set yet, but I guess it's not before 2012. Thus there's no hurry to commit now.

jazzynico (jazzynico) wrote :

@Nick - Would you be willing to release a new version so that I could update the Inkscape trunk?
Lots of things have changed recently and it would be a good idea to test your extension correctly with the trunk as soon as possible (FYI, 0.49 could be out next Autumn, a bit earlier than I first thought).

Nick (xepecine) wrote :

Give me 5 days :).
It's really hard to make a release, every time I think there's one thing to improve before release :).

Can you point me to place where I can get 0.49 to test it with gcodetools?
And how can we translate extension? There are some people on cnc-club.ru that have already translated Gcodetools into Spanish and Portuguese just translating .inx and .py files. And I can translate it into Russian. We want to make the translations using native get_text function.

jazzynico (jazzynico) wrote :

@Nick
The INX and Python files don't need to be directly translated. Instead, we add the original version in the Inkscape source and compile it so that the strings are translatable in the global Inkscape PO file. Thus to make Gcodetools translatable, it first needs to be in the trunk. Then you can translate it to any language with poedit or the PO editor of your choice (the PO files are located in http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/files/head:/po/) and attach the translated PO file to a new report so that it can be tested and committed.

As for the 0.49 version, you can either compile it or download a binary version. Did you check http://inkscape.org/download/ ?

ScislaC (scislac) wrote :

JazzyNico: When you update it in trunk, please shoot me a quick email to let me know so I can grant Nick commit access.

Nick (xepecine) wrote :

Do you know where can I get 0.49 binary for Ubuntu or Debian there are only win binaries :(.
Autopackage and 0install are available only for old versions. And Inkscape nightly ppa if 40 weeks out of date...

ScislaC (scislac) wrote :

Looks like it just built an hour ago... https://launchpad.net/~inkscape.dev/+archive/trunk

Note, it will replace the stable version you have installed and you will have to install it via synaptic to force the version (the current way it's names the one in Ubuntu's PPA is viewed as newer).

Nick (xepecine) wrote :

Hi!

We've made Gcodetools 1.7 release.

You can get it from http://launchpad.net/gcodetools or lp:gcodetools

All files that are needed for the new version are in the stable dir. Other files are not needed.

ScislaC (scislac) wrote :

Nick: You now have commit access, please commit to Inkscape trunk and wrap up this report. :) Welcome to the team!

Nick (xepecine) wrote :

Thanks for the welcome greetings! I'll try my best not to break anything important :)!

PS I've commited changes in rev 10417.

How often is .po file updated? When should I tell people to start to translate extension?

~suv (suv-lp) wrote :

> I'll try my best (…)
> PS I've commited changes in rev 10417.

Seems like you committed a lot more "modified" files than intended:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/10417>

Can you trace down why those files are modified in your local branch or checkout? AFAICT from the web interface there are no obvious changes, but maybe it's whitespace, file format or permissions? (I haven't updated my local branch yet).

> How often is .po file updated?

JazzyNico will take care of the translation files (he's on vacation this week).

Nick (xepecine) wrote :

I saw that modified files... And I thought, that I've done something wrong, then I got a new branch of inkscape, and checked bzr status just after that. And it said that those files had been modified, so I thought that's fine and that's the way it should be...

I'm confused now... I've not done anything to that files and bazaar say that they are modified....

What should I do?

> JazzyNico will take care of the translation files (he's on vacation this week).
Ok, I'll wait :).

~suv (suv-lp) wrote :

> I'm confused now... I've not done anything to that files
> and bazaar say that they are modified....
>
> What should I do?

Not sure (I'm not an experienced bzr user either) - you might ask on the mailing list (inkscape-devel) if anything needs to be reverted, or how it could be prevented in later commits.

ScislaC (scislac) wrote :

Nick: Just prior to committing, if you run into files it claims are modified, bzr revert those files and bzr status check again. In my experience, it cleans those types of situations up.

~suv (suv-lp) wrote :

r10417 fails to build: the added and removed INX files need to be updated in 'share/extensions/Makefile.am' too:

make[4]: *** No rule to make target `gcodetools_all_in_one.inx', needed by `all-am'. Stop.

(See also the initial commit in r9818:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/9818>)

Build succeeds on Mac OS X 10.5.8 (i386) with attached patch - please review.

~suv (suv-lp) wrote :

Build failure fixed in r10418 by ScislaC.

Alvin Penner (apenner) wrote :

some of the differences in files were caused by different line termination conventions.
- for example the file packaging/win32/ifexist.nsh from rev 10416 contained the typical Windows line termination of CR/LF
- the same file in rev 10417 contained only LF, as per any non-Windows platform

Nick (xepecine) wrote :

Why does bzr modifies the files itself with out any prompting?
I'll do revert next time I see such behavior.

PS sorry for the build failure, I did not know that I have to make changes in makefile :(

Just some more fixes against the current version (anlge->angle, reduse->reduce).

And please remove gcodetools_all_in_one.inx from POTFILES.in (it breaks extraction).

Thanks again for your work. ;)

Oops... And please change "Noting" in gcodetools.py:3320 to "Nothing".

Thanks again.

jazzynico (jazzynico) wrote :

POTFILES.in updated in the trunk, revision 10440.

@Nick - Why did you remove the translation underscore in the name elements (should be <_name></_name>)?

I realize I didn't explain you how to correctly update the extension. There are two files you may need to modify:
* po/POTFILES.in, which lists the files that have translatable content.
* share/extensions/Makefile.am, in order to copy the files to the install location.
Of course, there's nothing to change if you don't add or delete INX or py files.

Thanks for the update!

Nick (xepecine) wrote :

 > @Nick - Why did you remove the translation underscore in the name elements (should be <_name></_name>)?

I've not removed them. All of them shouldd be like if element has gui-text :
<param type='optiongroup' name='tools-library-type' _gui-text="Tools type:">
or (if it has not)
<_option value='graffiti'>graffiti</_option>

>* po/POTFILES.in, which lists the files that have translatable content.
> * share/extensions/Makefile.am, in order to copy the files to the install

Ok, will change them if it will be needed next time.

PS Thanks for the typos fix.

jazzynico (jazzynico) wrote :

@Nick - It ok for the params, but the name element (which gives the name of the extension in the menu) should have the underscore.
BTW, Inkscape revision 10446 fixes some typos in the INX files. Would you be willing to back-port it (and also correct the ones found by Yuri) to the Gcodetools trunk?
Thanks!

Kris (kris-degussem) wrote :

Are changes referred to in comments 28, 29, and 32 being taken care off?
And hence, if copied into inkscape, can this bug be closed?

Kris (kris-degussem) wrote :

See also Bug #980527 . Probably worth treating this one simultaneously.

jazzynico (jazzynico) on 2012-05-09
Changed in inkscape:
assignee: JazzyNico (jazzynico) → Nick (xepecine)
status: Triaged → In Progress

Added <_name> and </_name> to all gcodetools INX files in rev 12017.

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers