|09:12| < su-v> JonCruz: busy? need your advice :) |09:13| < JonCruz> sure |09:13| < JonCruz> as long as my connection holds |09:13| < su-v> a patch provided to build against libpng 1.5 - is it safe to assume it will work with older libpng versions? |09:13| < su-v> |09:15| < JonCruz> su-v: let's see. Libpng is notoriously tricky |09:15| < su-v> I guess many still use 1.2 (MacPorts has 1.4.5 now, but they are unlikely to move to 1.5 before waiting at least another year) |09:16| < JonCruz> Eeeeeeeek!!! reverse hungarian!!! |09:16| < JonCruz> ;-) |09:17| < JonCruz> FAR *?!?!?!??! |09:17| < JonCruz> eeeeeeeeeeeeeeeek!!! |09:17| < JonCruz> 16-bit MS-isms! |09:18| < JonCruz> su-v: ok. That does look safe, as the type is in 1.4 |09:18| < su-v> and 1.2? |09:19| < su-v> no longer in use on supported platforms? |09:19| < su-v> devlibs for windows builds e.g. still have libpng 1.2.8 |09:20| < JonCruz> su-v: UH OH!!! |09:20| < JonCruz> su-v: I take back what I said. The function signature is different |09:21| < JonCruz> su-v: my version of that declaration takes a png_charp not a png_bytep |09:22| < JonCruz> ? |09:28| < su-v> JonCruz: in png.h? |09:28| < JonCruz> su-v: and also check pngconf.h |09:28| < JonCruz> the latter has the typedefs |09:29| < JonCruz> png.h has the function that will be called. You want to look at each param and see that we have the variable we're passing as the proper type. |09:29| < su-v> if I search for "png_get_iCCP" in png.h, it seems to take a 'png_charpp profile' here (line 2381) |09:29| < JonCruz> su-v: *also* |09:30| < JonCruz> su-v: you want to check the 1.2 and 1.5 versions of those files to make sure they did not tweak things and change params |09:34| < su-v> png.h, line 852 has a comment ... |09:34| < su-v> /* Note to maintainer: should be png_bytep */ |09:35| < JonCruz> su-v: aha! in which version? |09:35| < su-v> libpng 1.4.5 |09:35| < su-v> the current one in MacPorts |09:36| < su-v> http://inkscape.pastebin.com/3EZzAmKp |09:36| < su-v> not sure if related (you know I'm not coding ;) ) |09:42| < su-v> png.h from libpng 1.5: |09:45| < su-v> same from libpng stable 1.4.0: |09:46| < su-v> same from libpng stable 1.2.42: |09:50| < su-v> and it's mentioned in the readme file of 1.5.1: |09:50| < su-v> Added a note in the manual that the type of the iCCP profile was changed |09:50| < su-v> from png_charpp to png_bytepp in png_get_iCCP(). Similarly, |09:50| < su-v> it was changed from png_charpp to png_const_bytepp in png_set_iCCP(). |09:50| < su-v> |09:53| < JonCruz> su-v: but it looks like 1.5.0 |09:57| < JonCruz> su-v: we need to pinpoint when that happened, and add the proper major-minor-rev check |09:58| ## JonCruz [~joncruz@adsl-76-233-84-11.dsl.lsan03.sbcglobal.net] has quit [Quit: Cebuuuuuuu!]