dbus builds no more

[[e-mail]]

extension/dbus/dbus-init.cpp: In function ‘void Inkscape::Extension::Dbus::init()’:
extension/dbus/dbus-init.cpp:87: warning: unused variable ‘obj’
extension/dbus/dbus-init.cpp: In function ‘gchar* Inkscape::Extension::Dbus::init_document()’:
extension/dbus/dbus-init.cpp:109: error: ‘sp_document_new’ was not declared in this scope
./document.h:99: error: ‘gchar* SPDocument::name’ is protected
extension/dbus/dbus-init.cpp:112: error: within this context
extension/dbus/dbus-init.cpp:103: warning: unused variable ‘result’
extension/dbus/dbus-init.cpp:104: warning: unused variable ‘error’
make[3]: *** [extension/dbus/dbus-init.o] Error 1
make[3]: Leaving directory `/home/joakim/current/build_myprojs/inkscape/inkscape/src'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/joakim/current/build_myprojs/inkscape/inkscape/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/joakim/current/build_myprojs/inkscape/inkscape'
make: *** [all] Error 2
[joakim@localhost inkscape]$ make
make all-recursive
make[1]: Entering directory `/home/joakim/current/build_myprojs/inkscape/inkscape'
Making all in src
make[2]: Entering directory `/home/joakim/current/build_myprojs/inkscape/inkscape/src'
make all-am
make[3]: Entering directory `/home/joakim/current/build_myprojs/inkscape/inkscape/src'
  CXX extension/dbus/dbus-init.o
extension/dbus/dbus-init.cpp: In function ‘void Inkscape::Extension::Dbus::init()’:
extension/dbus/dbus-init.cpp:87: warning: unused variable ‘obj’
extension/dbus/dbus-init.cpp: In function ‘gchar* Inkscape::Extension::Dbus::init_document()’:
extension/dbus/dbus-init.cpp:109: error: ‘sp_document_new’ was not declared in this scope
./document.h:99: error: ‘gchar* SPDocument::name’ is protected
extension/dbus/dbus-init.cpp:112: error: within this context
extension/dbus/dbus-init.cpp:103: warning: unused variable ‘result’
extension/dbus/dbus-init.cpp:104: warning: unused variable ‘error’
make[3]: *** [extension/dbus/dbus-init.o] Error 1
make[3]: Leaving directory `/home/joakim/current/build_myprojs/inkscape/inkscape/src'
make[2]: *** [all] Error 2
make[2]: Leaving directory `/home/joakim/current/build_myprojs/inkscape/inkscape/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/home/joakim/current/build_myprojs/inkscape/inkscape'
make: *** [all] Error 2

[su_v (suv-lp)]

Do you remember which revision last built with dbus enabled?

Possibly related to the C++-ification merge in r9946 and later.
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/9946>

[su_v (suv-lp)]

Also, could you add information about your OS/Distribution and GTK+/GLib version?

[[e-mail] (joakim-verona)]

current 9994
last known working 9834

fedora 13

[jazzynico (jazzynico)]

Confirmed on Ubuntu 10.04, Inkscape trunk revision 9999.

[[e-mail] (joakim-verona)]

I made a patch that makes compilation work again.
Could it be applied?

[jazzynico (jazzynico)]

Test in progress on Ubuntu 10.04...

[jazzynico (jazzynico)]

Fix confirmed (clean build needed) and committed in the trunk, revision 10011.
Thanks!

[jazzynico (jazzynico)]

Unfortunately it fails on Ubuntu 10.10 (I've just upgraded), even after a clean build. But the error messages are different:
----
In file included from /usr/include/giomm-2.4/giomm/dbusconnection.h:34,
                 from /usr/include/giomm-2.4/giomm.h:32,
                 from /usr/include/gtkmm-2.4/gtkmm.h:88,
                 from ./file.h:18,
                 from extension/dbus/dbus-init.cpp:28:
/usr/include/giomm-2.4/giomm/dbusmessage.h:51: error: expected identifier before numeric constant
/usr/include/giomm-2.4/giomm/dbusmessage.h:51: error: expected ‘}’ before numeric constant
/usr/include/giomm-2.4/giomm/dbusmessage.h:51: error: expected unqualified-id before numeric constant
/usr/include/giomm-2.4/giomm/dbusmessage.h:186: error: ‘DBusMessage_Class’ does not name a type
In file included from /usr/include/giomm-2.4/giomm/dbusconnection.h:34,
                 from /usr/include/giomm-2.4/giomm.h:32,
                 from /usr/include/gtkmm-2.4/gtkmm.h:88,
                 from ./file.h:18,
                 from extension/dbus/dbus-init.cpp:28:
/usr/include/giomm-2.4/giomm/dbusmessage.h:352: error: ‘DBusMessageType’ does not name a type
/usr/include/giomm-2.4/giomm/dbusmessage.h:359: error: ‘DBusMessageType’ has not been declared
/usr/include/giomm-2.4/giomm/dbusmessage.h:706: error: expected declaration before ‘}’ token
----

But this time it's not in our code, and other projects are also affected (see http://www.mangler.org/forums/mangler-support/cant-compile-anymore/).

[jazzynico (jazzynico)]

FYI, dbus now compiles correctly on Ubuntu 10.10, thanks to a patch by Krzysztof Kosiński (committed revision 10031).