[Tweak tool] crash in sp_cursor_bitmap_and_mask_from_xpm() when selecting "Attract (Repel)" mode

[su_v]

Inkscape 0.48+devel r9862 on OS X 10.5.8:
Regression: Inkscape crashes when clicking on the 'Attract (Repel)' mode icon on the tweak tool controls bar.

Steps to reproduce:
1) open new document
2) switch to the tweak tool (with or without a path selected)
3) click on the button 'Attract parts of paths towards the cursor'

-> Inkscape crashes.

The regression seems to have been introduced between r9737 and r9743, possibly caused by the new code for the color preview in the cursor in r9743.

tested with archived local builds: 9737 ok, 9743 crash
no console messages, crash report attached

[su_v (suv-lp)]

Note: does not affect the 0.48.x branch.

[su_v (suv-lp)]

@Jasper - subscribing you here: could you take a look if this crash is caused by revision 9743 for the color preview in the cursor symbols?

[su_v (suv-lp)]

patch to fix corrupt cursor icons (incorrect number of colors in two cursor icons for the tweak tool)

tested with Inkscape 0.48+devel r9862 on OS X 10.5.8: Inkscape no longer crashes when selecting 'Attract (Repel)' mode

[jazzynico (jazzynico)]

Bug confirmed on Ubuntu 10.04.
Fix tested successfully.

[Jaspervdg (jaspervdg)]

Great to see this already fixed!

[su_v (suv-lp)]

@Jasper - would it make sense to add some error checking in the code that reads from xpm so that Inkscape doesn't crash when there is a small error in the xpm source?

I can't code C++ myself and I only figured out the above fix by chance -- because Inkscape showed small errors when displaying on-canvas the two xpm files from the source tree (linked as images) while previewing and testing bug #614500.

[Jaspervdg (jaspervdg)]

I guess it would make sense to add some error checking, but in this case it's not that trivial (I think), at least not to make it so that it outputs something sensible (other than a message that something is wrong with the xpm). If I find some time I'll have a look if it can be made a bit more robust (could take a couple of months).

[Krzysztof Kosinski (tweenk)]

Applied in trunk 9912 / branch 9729