Colour palettes not translatable

Bug #667402 reported by Kris
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
jazzynico

Bug Description

At the moment there all colour names in the palettes are not translatable. They popup in the interface as English tooltips.
Hover the mouse over the the colour palette bar at the bottom or hover over the colour palette window (CTRL+shift+W)...
Making 30% gray, red, yellow, ... list as the local language would greatly enhance the professional impression of Inkscape.

jazzynico (jazzynico)
tags: added: color i18n translation ui
Changed in inkscape:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
jazzynico (jazzynico) wrote :

I'll try to take a look before 0.49...

Changed in inkscape:
assignee: nobody → JazzyNico (jazzynico)
milestone: none → 0.49
Revision history for this message
jazzynico (jazzynico) wrote :

Patch committed in the trunk, revision 9870.
Translation restricted to real strings, names with RVB value only are not marked translatable.
About 400 new strings added the po template...

Changed in inkscape:
status: Confirmed → Fix Committed
Changed in inkscape:
status: Fix Committed → In Progress
Revision history for this message
Jon A. Cruz (jon-joncruz) wrote :

Seems good for compiled-in data. For a long term solution we will probably need something that will work with palettes added in the field (the CREATE color format includes translations http://create.freedesktop.org/wiki/Swatches_-_colour_file_format/Propositions#Proposition_G )

However, for this change I think we need to have a translation context added to keep things to pulling only color names, and not random UI strings.
http://library.gnome.org/devel/glib/stable/glib-I18N.html#g-dpgettext2

Revision history for this message
jazzynico (jazzynico) wrote :

> I think we need to have a translation context

Ok. It also needs an additional check for no-c-format strings. I'll commit it (and context) later today.

Revision history for this message
jazzynico (jazzynico) wrote :

Context, no-c-format and comments committed in the trunk, revision 9871.

Revision history for this message
jazzynico (jazzynico) wrote :

@Jon, is there a plan to implement the long term solution before 0.49?
If not, do you see something else that must be done now before closing this report?

Revision history for this message
Jon A. Cruz (jon-joncruz) wrote :

It is expected that newer formats will be added for 0.49, but this fix probably is good for the .gpl ones. Given that the context key is fairly explicit, I don't foresee any significant issues.

Changed in inkscape:
status: In Progress → Fix Committed
Revision history for this message
jazzynico (jazzynico) wrote :

Reopening. Some of the palettes added in the translation list are too complex or don't really need to be translated. I suggest that we just keep Inkscape default, SVG and tango in the list and make all the others untranslatable.

Changed in inkscape:
status: Fix Committed → In Progress
Revision history for this message
jazzynico (jazzynico) wrote :

Palette list reduced as of revision 10072.

Changed in inkscape:
status: In Progress → Fix Committed
jazzynico (jazzynico)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.