Aborted output extensions create an empty file

Bug #652943 reported by jazzynico on 2010-10-01
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Low
jazzynico
inkscape (Ubuntu)
Low
Unassigned

Bug Description

When an output extension fails, an unnecessary empty file is created.

Steps to reproduce:
1. Open a blank new document.
2. Use File>Save As, Gimp XCF output.
3. Accept the extension's parameters.
4. Since there's nothing to export, the extension fails and returns an error message.
5. An empty file is created in the location set in 2.

Also reproduced with SK1 export (when saving an empty document) and Compressed SVG+media (when debugging it...).

jazzynico (jazzynico) on 2010-10-01
tags: added: exporting extensions-plugins
Changed in inkscape:
assignee: nobody → JazzyNico (jazzynico)
importance: Undecided → Low
Changed in inkscape:
status: New → Triaged
Changed in inkscape (Ubuntu):
status: New → Triaged
importance: Undecided → Low
jazzynico (jazzynico) wrote :

Fix committed in the trunk, revision 9815.
Tested on Ubuntu 10.04, no apparent regression.

An additional message is sent by the extension system (not the python script!) to notify users that the file was not saved. This is a standard message which usually show when the file can't be written to the disk, but I feel it can be used here too. Tell me if you think it's not useful at all.

Please test!

Changed in inkscape:
milestone: none → 0.49
status: Triaged → Fix Committed
Alex Valavanis (valavanisalex) wrote :

Attaching upstream patch for backport testing in Ubuntu.

tags: added: patch-accepted-upstream
Changed in inkscape:
status: Fix Committed → Fix Released
Changed in inkscape (Ubuntu):
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Duplicates of this bug

Other bug subscribers