BAD_SIZEOF in inkscape/src/extension/internal/pdfinput/svg-builder.cpp

[Vaughn Spurlin]

BAD_SIZEOF in inkscape/src/extension/internal/pdfinput/svg-builder.cpp

In Inkscape::Extension::Internal::SvgBuilder…::pushTransparencyGroup(...):
The sizeof operator was applied to an unintended variable or expression, such as a pointer variable instead of its target (CWE-467).

1766void SvgBuilder::pushTransparencyGroup(GfxState *state, double *bbox,
 1767 GfxColorSpace *blending_color_space,
 1768 bool isolated, bool knockout,
 1769 bool for_softmask) {
 1770
 1771 // Push node stack
 1772 pushNode("svg:g");
 1773
 1774 // Setup new transparency group
 1775 SvgTransparencyGroup *transpGroup = new SvgTransparencyGroup;
Taking the size of pointer parameter "bbox" is suspicious.
 1776 memcpy(&transpGroup->bbox, bbox, sizeof(bbox));

[Jon A. Cruz (jon-joncruz)]

Confirmed incorrect handling of data types.