UNREACHABLE in /inkscape/src/style.cpp

[Vaughn Spurlin]

UNREACHABLE in /inkbugs/inkscape/src/style.cpp (lines 2439-4439)

In sp_style_write_istring(...):
Code block is unreachable because of the syntactic structure of the code (CWE-561).

 3582 if (val->inherit) {
 3583 return g_snprintf(p, len, "%s:inherit;", key);
 3584 } else {
 3585 gchar *val_quoted = css2_escape_quote(val->value);
 3586 if (val_quoted) {
 3587 return g_snprintf(p, len, "%s:%s;", key, val_quoted);
This code cannot be reached: "g_free(val_quoted);".
 3588 g_free (val_quoted);
 3589 }
 3590 }

[Vaughn Spurlin (vspurlin)]

fix suggestion 2010-07-25:
 delete line 3588 g_free (val_quoted);

fix reason:
  if css2_escape_quote(...) returned NULL, then val_quoted does not need to be freed.

[Jon A. Cruz (jon-joncruz)]

There's more to consider here. The early returns need to be refactored away.

[Kris (kris-degussem)]

Committed fix in revision 11668.