Tweak tool using wrong cursor

[Preben S]

Using XP r9455

With the first six tweak tool modes, that is those, that act on objects rather then nodes, only the first icon is used for the cursor in all six cases.

I hope I have described it clear enough, I will not be near a computer in the next week or so.

[~suv (suv-lp)]

reproduced with Inkscape 0.47+devel r9456 on OS X 10.5.8

[jazzynico (jazzynico)]

Reproduced on XP, Inkscape 0.47.
But it seems that the missing pixmaps don't exist at all (or at least not in src/pixmaps/).

[~suv (suv-lp)]

Related source code for tweak tool context:
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/view/12170/src/tweak-context.cpp#L185>

See also:

Revision 6843 (2008-09-19)
  transform modes for tweak tool
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/6843>

Subject: Re: Fwd: NEW: more modes in Tweak tool (2008-09-26)
  «The only thing that's still missing is the mouse cursors for all
  modes. If anyone can draw at least some of them (see existing ones in
  src/pixmaps as examples, you can use text editor or Gimp to edit the
  xpm files) that would be really helpful.»
<http://article.gmane.org/gmane.comp.graphics.inkscape.devel/27777>

Revision 8298 (2009-07-18)
  Use cursor-tweak-move.xpm for all object modes and cursor-color.xpm
  for color paint mode until someone creates new cursors. This at least
  gives consistency as to which cursor is used in each mode.
<http://bazaar.launchpad.net/~inkscape.dev/inkscape/trunk/revision/8298>

[Christoffer Holmstedt (christoffer-holmstedt)]

I started to work on this today.

[Christoffer Holmstedt (christoffer-holmstedt)]

Fix available in lp:~christoffer-holmstedt/inkscape/lp587729-tweak-tool-cursors

[Christoffer Holmstedt (christoffer-holmstedt)]

Is it only "Fix committed" when it goes into trunk?

[~suv (suv-lp)]

Fix tested ok with Inkscape 0.48+devel r12281 on OS X 10.7.5 (GTK+/Quartz 2.24.17)

<opinion>
While testing the tweak tool with new cursor symbols, I was wondering whether it wouldn't be better to also redesign the current symbol used for 'Move objects in any direction' - to better match the newly added ones?
</opinion>

[~suv (suv-lp)]

Just noticed that clang [*] shows lots of warnings when compiling the new pixmaps.

-----
[*] Apple clang version 3.1 (tags/Apple/clang-318.0.58) (based on LLVM 3.1svn)

[Christoffer Holmstedt (christoffer-holmstedt)]

@suv-lp yea, was thinking about that as well. I will look in to that during the weekend.

[Christoffer Holmstedt (christoffer-holmstedt)]

#9 is an answer to first reply about creating a new cursor for the first "move any direction".

Concerning the warnings, yea, so you don't get thoose warnings for the old cursors? I created the pixmaps with Gimp and as I didn't see any difference in my cursors with the old ones I assumed the warnings were for all cursors. I look in to that as well.

[~suv (suv-lp)]

> you don't get thoose warnings for the old cursors?

- No such warnings for the existing pixmaps
- llvm-gcc-4.2 is equally noisy about the new ones

[~suv (suv-lp)]

The difference between the old and new pixmaps AFAICT is the missing 'const' in the new ones (the compiler warnings disappear once 'const' has been added to the new pixmaps).

[Christoffer Holmstedt (christoffer-holmstedt)]

aha, right. Didn't see that one. I will fix that as well.

[Christoffer Holmstedt (christoffer-holmstedt)]

I've update the related branch with revision 12279 which includes fixes as requested by ~suv-lp.

- Warnings during compilation has been fixed
- The original "Move objects in any direction" has been replaced with a cursor that looks similiar to the related new cursors.

[~suv (suv-lp)]

r12279 of the branch compiles without warnings on OS X 10.7.5 (preview of the new cursors attached).

[Jon A. Cruz (jon-joncruz)]

Fix committed in revision 12321.