Tweak tool using wrong cursor
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
| Inkscape |
Low
|
Christoffer Holmstedt |
Bug Description
Using XP r9455
With the first six tweak tool modes, that is those, that act on objects rather then nodes, only the first icon is used for the cursor in all six cases.
I hope I have described it clear enough, I will not be near a computer in the next week or so.
Related branches
su_v (suv-lp) wrote : | #1 |
tags: | added: ui |
Changed in inkscape: | |
importance: | Undecided → Low |
status: | New → Confirmed |
jazzynico (jazzynico) wrote : | #2 |
Reproduced on XP, Inkscape 0.47.
But it seems that the missing pixmaps don't exist at all (or at least not in src/pixmaps/).
su_v (suv-lp) wrote : | #3 |
Related source code for tweak tool context:
<http://
See also:
Revision 6843 (2008-09-19)
transform modes for tweak tool
<http://
Subject: Re: Fwd: NEW: more modes in Tweak tool (2008-09-26)
«The only thing that's still missing is the mouse cursors for all
modes. If anyone can draw at least some of them (see existing ones in
src/pixmaps as examples, you can use text editor or Gimp to edit the
xpm files) that would be really helpful.»
<http://
Revision 8298 (2009-07-18)
Use cursor-
for color paint mode until someone creates new cursors. This at least
gives consistency as to which cursor is used in each mode.
<http://
tags: | added: easy-fix |
Changed in inkscape: | |
status: | Confirmed → Triaged |
I started to work on this today.
Changed in inkscape: | |
assignee: | nobody → Christoffer Holmstedt (christoffer-holmstedt) |
Fix available in lp:~christoffer-holmstedt/inkscape/lp587729-tweak-tool-cursors
Changed in inkscape: | |
status: | Triaged → Fix Committed |
Changed in inkscape: | |
status: | Fix Committed → In Progress |
Is it only "Fix committed" when it goes into trunk?
su_v (suv-lp) wrote : | #7 |
Fix tested ok with Inkscape 0.48+devel r12281 on OS X 10.7.5 (GTK+/Quartz 2.24.17)
<opinion>
While testing the tweak tool with new cursor symbols, I was wondering whether it wouldn't be better to also redesign the current symbol used for 'Move objects in any direction' - to better match the newly added ones?
</opinion>
su_v (suv-lp) wrote : | #8 |
Just noticed that clang [*] shows lots of warnings when compiling the new pixmaps.
-----
[*] Apple clang version 3.1 (tags/Apple/
@suv-lp yea, was thinking about that as well. I will look in to that during the weekend.
#9 is an answer to first reply about creating a new cursor for the first "move any direction".
Concerning the warnings, yea, so you don't get thoose warnings for the old cursors? I created the pixmaps with Gimp and as I didn't see any difference in my cursors with the old ones I assumed the warnings were for all cursors. I look in to that as well.
su_v (suv-lp) wrote : | #11 |
> you don't get thoose warnings for the old cursors?
- No such warnings for the existing pixmaps
- llvm-gcc-4.2 is equally noisy about the new ones
su_v (suv-lp) wrote : | #12 |
The difference between the old and new pixmaps AFAICT is the missing 'const' in the new ones (the compiler warnings disappear once 'const' has been added to the new pixmaps).
aha, right. Didn't see that one. I will fix that as well.
I've update the related branch with revision 12279 which includes fixes as requested by ~suv-lp.
- Warnings during compilation has been fixed
- The original "Move objects in any direction" has been replaced with a cursor that looks similiar to the related new cursors.
su_v (suv-lp) wrote : | #15 |
r12279 of the branch compiles without warnings on OS X 10.7.5 (preview of the new cursors attached).
Jon A. Cruz (jon-joncruz) wrote : | #16 |
Fix committed in revision 12321.
Changed in inkscape: | |
status: | In Progress → Fix Committed |
milestone: | none → 0.49 |
Changed in inkscape: | |
status: | Fix Committed → Fix Released |
reproduced with Inkscape 0.47+devel r9456 on OS X 10.5.8