Download links don't escape the "+" character, breaks in some browsers

[Groxx]

Pretty simple. Exists on at least Safari + OSX Leopard, and from what I've heard Firefox as well, possibly on other download links. "plus" characters should be escaped with "%2B", many browsers attempt to download it with the "+" replaced with a space.

Link given: http://downloads.sourceforge.net/inkscape/Inkscape-0.47-1.LEOPARD+.dmg
Link required: http://downloads.sourceforge.net/inkscape/Inkscape-0.47-1.LEOPARD%2B.dmg

[su_v (suv-lp)]

confirmed with Firefox 3.5.9 on OS X 10.5.8

this relates to the download button on the frontpage http://www.inkscape.org which - depending on the users OS - links to the corresponding package on sf.net:

    window.onload = function()
    {
        if (navigator.platform.indexOf("Win32") != -1) {
            document.getElementById("downloadnowlink").href =
                "http://downloads.sourceforge.net/inkscape/Inkscape-0.47-3.exe";
        }else if (navigator.userAgent.indexOf("Mac OS X") != -1) {
            document.getElementById("downloadnowlink").href =
- "http://downloads.sourceforge.net/inkscape/Inkscape-0.47-1.LEOPARD.dmg";
+ "http://downloads.sourceforge.net/inkscape/Inkscape-0.47-1.LEOPARD%2B.dmg";
        }
    }

[su_v (suv-lp)]

sorry, typo:

- "http://downloads.sourceforge.net/inkscape/Inkscape-0.47-1.LEOPARD+.dmg";
+ "http://downloads.sourceforge.net/inkscape/Inkscape-0.47-1.LEOPARD%2B.dmg";

[su_v (suv-lp)]

file to be updated/modifed (or tested if the escaped '+' character works for all different use cases of $macosx_leopard):

http://inkscape.svn.sourceforge.net/viewvc/inkscape/inkscape_web/trunk/download/packages-url.inc?view=log

[su_v (suv-lp)]

@Michael - subscribing you to this report since you both can decide on the file name for the package on source forge as well have the permissions to edit the download string for PHP ($macosx_leopard) in 'packages-url.inc '. Maybe the download link on inkscape.org can be fixed for 0.48?

[su_v (suv-lp)]

Fix committed by ScislaC in SVN revision 22751
<http://inkscape.svn.sourceforge.net/viewvc/inkscape?view=revision&revision=22751>

Download link on <http://www.inkscape.org> now works as expected (tested with Firefox 3.6.8 and Safari 5.0)