Initial spray tool options shown in the controls bar are not used

[su_v]

Inkscape 0.47+devel r9322 on OS X 10.5.8 (new preferences)

When using the spray tool with default unchanged options (e.g. when launching Inkscape after removing 'preferences.xml') the options as shown on the spray tool controls bar are not used:

- Mode is set to 'Clones' but the spray tool creates copies
- Amount is set to '70' but far fewer objects are sprayed
- ...

The values for the spray tool in 'src/preferences-skeleton.h' seem to be copied from the tweak tool. The initially shown options on the spray tool controls bar appear to be preset values but aren't actually used by the tool. Only after changing the toggles and sliders the actual settings are used and stored in the preferences.

steps to reproduce:

1) rename 'preferences.xml' and launch Inkscape
2) create a small object (e.g. a star)
3) select the star and switch to the spray tool
4) without changing any options start spraying
5) the result doesn't correspond to the options as shown on the controls bar

[jazzynico (jazzynico)]

Confirmed on Ubuntu 9.10, Inkscape bzr rev. 9339.

Also noticed that zooming in and out switches the mode from Clones to Copies automatically.

[jazzynico (jazzynico)]

> The values for the spray tool in 'src/preferences-skeleton.h' seem to be copied from the tweak tool.

Exact. Some Tweak parameters are no longer used by the Spray tools, and some new Spray parameters are not set at all.

[jazzynico (jazzynico)]

Fix committed in bzr rev. 9341.
Please test.

[su_v (suv-lp)]

Fix confirmed in Inkscape 0.47+devel r9341 (OS X 10.5.8)

Two related questions:
1) why are the 'default' values (right-click a slider to see/choose it) different from what is initially set?
2) multiple document windows: when changing the controls bar options in one window, the spray tool controls in the other windows don't update, but the new values are used when spraying. r9311 and r9316 address this problem (see bug #426032) for the node tool - any chance this could be implemented for the spray tool as well? Or should we use a new 'master' bug report tracking this issue for the controls bar of all tools?

[jazzynico (jazzynico)]

> 1) why are the 'default' values (right-click a slider to see/choose it) different from what is initially set?

They are not correctly defined in the toolbox code. Patch (with lots of other spray tool fixes) in progress.

> 2) multiple document windows...

Fixed (locally) for the pressure button thanks to Jon's new PrefPusher. But apparently it's a bit more complex to make it work with the other widgets...