Undo History Stays Open After File Closed; Crashes When Used

[Rena Kunisaki]

1) Open or create a file.
2) Open the Undo History window.
3) Make some changes to the file. They do not need to be saved.
4) Open a second file, and close the first.
5) The Undo History window stays open, displaying the actions performed on the first file. Clicking an item in the list crashes Inkscape.

Expected behaviour: The window should switch to display the history of the current document, or close.

[jazzynico (jazzynico)]

Oops, forgot to test the crash...
I can't reproduce it on Windows XP, Inkscape 0.47 (with basic shapes).
Which Inkscape version is affected by this bug?
Could you please provide the steps that lead to the crash?
Thanks!

[jazzynico (jazzynico)]

Here's a list of reports which deal with that kind of issue:
https://bugs.launchpad.net/inkscape/+bugs?field.searchtext=crash+undo

[Rena Kunisaki (i-am-inuyasha)]

Version is 0.47 on Debian. Looks like any changes that generate undo history will work.

[Rena Kunisaki (i-am-inuyasha)]

Here's one reliable way to reproduce this issue:

1) Start Inkscape.
2) Open the Undo History window.
3) Draw a rectangle.
4) Go to File -> New.
5) Close the original window (in which you drew a rectangle) without saving. Note that "Create Rectangle" is still in undo history.
6) Click "[Unchanged]" in the undo history, and Inkscape crashes.

More generally, any time you close a window in which changes were made but keep the Undo History window open, then try to use the undo history, it crashes trying to modify the no-longer-open document.

[su_v (suv-lp)]

reproduced with Inkscape 0.47 and 0.47+devel r9292 on OS X 10.5.8

console message:

ERROR:document-undo.cpp:254:gboolean sp_document_undo(SPDocument*): assertion failed: (doc->priv != NULL)

[jazzynico (jazzynico)]

Also reproduced on Ubuntu, Inkscape 0.47 and rev 9295, and on Windows XP, Inkscape 0.47.
But I can't reproduce the crash on Windows XP, Inkscape 0.46. The undo history dialog displays wrong data, but doesn't crash Inkscape if I click on [Unchanged].

[su_v (suv-lp)]

related: bug #378097 “Crashes with several dokument.”

[Chris Morgan (chris.morgan)]

I reproduced this (without knowledge of this bug report) by reverting a document; its undo history remained and so I clicked on one, expecting it to crash. Then I tried it again in a console to get the error message and it matched the one reported above. Seems like exactly the same bug.

ERROR:document-undo.cpp:254:gboolean sp_document_undo(SPDocument*): assertion failed: (doc->priv != NULL)

[jazzynico (jazzynico)]

Recent gdb trace attached.

[John Smith (john-smithi)]

Should be fixed by trunk commit r11624.
When floating Undo History should now correctly switch to the active document.