Textual problems in 0.46+devel r21920

Bug #408093 reported by a_b
14
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
jazzynico

Bug Description

Typos and localization-related stuff in Inkscape.
UPDATE: some of the problems have been corrected, plus I added
the filenames to the list, so please see my comments below.

The description of the "Image Effects->Film grain" filter is incorrect.

The "Shadows and Glows->Fuzzy Glow" and "Shadows and Glows->Cutout Glow"
filters have the same description.

In the "Hatches (rough)" LPE, two input fields - "from 2nd to 1st side"
and "from 1st to 2nd side" - have the same comment.

The Air Spray filter's description text is "Air Spray; adjust the
Displacement Map amount", but this doesn't tell the user what
happens if he adjusts that amount.

Typo
----

"Position the <b>start point</b> of the arc or segment; with <b>Ctrl</b>to Ctrlto (there's no space)
snap angle; drag <b>inside</b> the ellipse for arc, <b>outside</b> for
segment"

"Postpone snapping as long as the mouse is moving, and then wait an
additional fraction of a second. This additional delay is specified here.
When set to zero or to a very small number, snapping will be immediate" full stop needed at end

"initialy" ll

"halfsturns", "half turns", "halfturns" should use the same form everywhere

"varrying" r

"The reference segment. Defaults to bbox diameter." diameter in a box?

"colour", "coloured", "colourizable" color

"Difficulty finding the image data." ??? was he able to find it or not?

"Path | Object to Path" submenu items are denoted by "->" elsewhere

"Failed to import the numpy module. This module is required by this
extension. Please install them and try again." just 1 module, so "them" should be "it"

"top most" topmost

"The first selected set an attribute in all others" sets

"When the set must be done?" When should the ...

"All selected ones transmits to the last one" transmit

"The list of values must have the same size of the attributes list." size as the

"more then one" than

"a event" an

"previews code" previous code?

"Same than" Same as

"reflexion" reflection

"Draw Circle About This Point" Around?

"Angle 'A'/radians:" should have a space at the end like the other similar strings

"controlable" ll

"transparency which displace" s

"which turn around " s

"gelatin" e

"Cuboctohedron" Cuboctahedron

Should be disambiguated (split)
-------------------------------

"Top" src/ui/dialog/layers.cpp, share/extensions/restack.inx.h

"Show:" src/dialogs/object-attributes.cpp, share/extensions/polyhedron_3d.inx.h

Untranslatable
--------------

"Lines" and "Polygons" in the Extrude extension

"This extension requires two selected paths. The second path must be exactly four nodes long." in the Envelope extension

the complete help text of the "Draw from triangle" extension

Appears in English, even if translated
--------------------------------------

"January ..." in the Calendar extension

"Sun Mon ..." in the Calendar extension

"This extension requires two selected paths." in the Perspective extension

"<none>" in Extensions->Raster->Colorize->CMS (also present in the general Color dialog)

Tags: translation ui
tags: added: translation ui
Revision history for this message
ivan louette (ivan-louette) wrote :

filters.svg fixed in rev 21992

ivan louette

Revision history for this message
a_b (arpad-biro) wrote :
Download full text (4.5 KiB)

Some of the problems have been corrected and I also found a new one,
so here's the current list. This time with filenames, so you don't need the
inkscape.pot file.

In the "Hatches (rough)" LPE, two input fields - "from 2nd to 1st side"
and "from 1st to 2nd side" - have the same comment.

Typo
----

src/object-edit.cpp:
"Position the <b>start point</b> of the arc or segment; with <b>Ctrl</b>to
snap angle; drag <b>inside</b> the ellipse for arc, <b>outside</b> for
segment" there's no space between "Ctrl" and "to"

src/ui/dialog/inkscape-preferences.cpp:
"Postpone snapping as long as the mouse is moving, and then wait an
additional fraction of a second. This additional delay is specified here.
When set to zero or to a very small number, snapping will be immediate" full stop needed at end

src/ui/dialog/inkscape-preferences.cpp:
"initialy" ll

src/live_effects/lpe-rough-hatches.cpp:
"halfsturns", "half turns", "halfturns" should use the same form everywhere

src/live_effects/lpe-rough-hatches.cpp:
"varrying" r

src/live_effects/lpe-vonkoch.cpp:
"The reference segment. Defaults to bbox diameter." diameter in a box?

src/ui/dialog/filter-effects-dialog.cpp:
share/extensions/polyhedron_3d.inx.h:
share/extensions/printing-marks.inx.h:
"colour", "coloured", "colourizable" color

share/extensions/extractimage.py:
"Difficulty finding the image data." ??? was he able to find it or not?

share/extensions/perspective.py:
share/extensions/summersnight.py:
"Path | Object to Path" submenu items are denoted by "->" elsewhere

share/extensions/polyhedron_3d.py:
"Failed to import the numpy module. This module is required by this
extension. Please install them and try again." just 1 module, so "them" should be "it"

share/extensions/polyhedron_3d.inx.h:
"Cuboctohedron" Cuboctahedron

share/extensions/pathalongpath.inx.h:
share/extensions/pathscatter.inx.h:
"top most" topmost

share/extensions/web-set-att.inx.h:
"The first selected set an attribute in all others" sets

share/extensions/web-set-att.inx.h:
"When the set must be done?" When should the ...

share/extensions/web-set-att.inx.h:
"The list of values must have the same size of the attributes list." size as the

share/extensions/web-set-att.inx.h:
"more then one" than

share/extensions/web-transmit-att.inx.h:
"All selected ones transmits to the last one" transmit

share/extensions/web-transmit-att.inx.h:
"a event" an

share/extensions/web-set-att.inx.h:
share/extensions/web-transmit-att.inx.h:
"previews code" previous code?

share/ex...

Read more...

a_b (arpad-biro)
description: updated
Revision history for this message
a_b (arpad-biro) wrote :

one more typo:

share/filters/filters.svg.h:
"whith"

Changed in inkscape:
status: New → In Progress
Revision history for this message
jazzynico (jazzynico) wrote :

Currently working on it. I hope it'll be ok for before the end of the week. Please comment if you see other textual problems.

Changed in inkscape:
assignee: nobody → JazzyNico (jazzynico)
Revision history for this message
Lucas Vieites (lucasvieites) wrote :

Adding comment by suggestion of Arpad Biro.
When I apply a filter to an object, say "Wrinkled varnish", the menu option appears correctly translated to spanish as "Barniz arrugado", but when I select the object, on the status bar I see the description of the object, for example: "Elipse; filtrado (Wrinkled varnish) en capa Capa 1. Pulse......". As you see, the name of the filter does not appear translated here.
I think it's this segment in the po file: the second "%s" is not getting the correct string.
 ============================
 #: ../src/sp-item.cpp:1065
 #, c-format
 msgid "%s; <i>filtered (%s)</i>"
 msgstr "%s; <i>filtrado (%s)</i>"
 ============================

Revision history for this message
jazzynico (jazzynico) wrote :

Ok, it's almost done.

Do someone know how to add a comment in an INX file? I need it to comment the disambiguation.

It seems that there's something broken with gettext and python. The marked strings, even when translated in the po file, appear in English. Not only the ones noticed by Arpad Biro, but all the python strings...

Revision history for this message
a_b (arpad-biro) wrote :

share/extensions/cdr_input.inx has a comment, it's the same syntax as in HTML

Revision history for this message
jazzynico (jazzynico) wrote :

> share/extensions/cdr_input.inx has a comment, it's the same syntax as in HTML
Thanks a_b, it works great!

What's in progress:
* I'm waiting for Aurium's response about web-*-att.inx (previews/previous).
* lpe-vonkoch.cpp, bbox diameter.
Proposal: "The reference segment. By default in the middle of the bbox's height."
Tell me what's your opinion about it. Asked JFB, but I'm not sure he's here today.
* Month and Days in svgcalendar. I really don't understand why it doesn't work. Probably caused by string type in the inx file.
* Python strings not translated. Global python and gettext problem.

Won't be fixed:
* "This extension requires two selected paths. The second path must be exactly four nodes long." in the Envelope extension. The string is split in two in the po file and thus IS translatable.
* "Draw Circle About This Point" in draw_from_triangle.inx. To me, about and around have the same sense in this context. Tell me if you think it's really worth changing it.

All the other bugs (including the filters' one, thanks to Ted's suggestion) are already in the patch.

Revision history for this message
a_b (arpad-biro) wrote :

> "By default in the middle of the bbox's height."
> Tell me what's your opinion about it.

Probably "Defaults to the horizontal midline of the bbox"?

> "Draw Circle About This Point" in draw_from_triangle.inx. To me, about and around have
> the same sense in this context. Tell me if you think it's really worth changing it.

Google "draw circle about" and "draw circle around". For me, "about" had
4 hits, "around" had 309 000. That's why I thought the latter one must be
a better choice.

Revision history for this message
jazzynico (jazzynico) wrote :

I've attach a global patch for this report. It fixes almost everything that's reported here except:
* Month and Days in svgcalendar.
* web-*-att.inx (previews/previous). No news from Aurium. Feel free to fix if you're sure of what to do.

Extra fixes:
* Removed the "selection" option in printing-marks.inx (it wasn't coded yet).
* Fixed a bug in the message box which appears when an extension is launched saying "'extension_name' working, please wait". Than name of the extension wasn't translated. Very short life box, unless you have an error ;)
* Also fixed my previous won't fix list items...

Ugly fix:
* My fix for the python error messages should be reviewed and probably rewritten. The problem was that an extra \n was added to the message (see src/extension/implementation/script.cpp , line 887). The patch is working, but since I'm not a native c++ writer, it really needs a review.

I'll send a separate patch for the remaining bugs.

Revision history for this message
jazzynico (jazzynico) wrote :

Oops, forgot a fix.
This one should be ok.

Revision history for this message
bbyak (buliabyak) wrote :

thanks, indeed your change in script.cpp I don't feel safe to commit yet, with its memcpy stuff it seems dangerous; i committed the rest of the patch, but for this one please get a review/approve/rewrite from one more developer, then I will commit it. You can open a separate bug for it, I'm closing this one.

Changed in inkscape:
status: In Progress → Fix Released
Revision history for this message
jazzynico (jazzynico) wrote :

Thanks bulia!
The script bug is now reported in Bug #425202.

Some issues are not fixed yet, and I have to rewrite the disambiguation fix. It doesn't work in inx files. I'll fix it in the cpp files instead.

Revision history for this message
su_v (suv-lp) wrote :

@JazzyNico - in Inkscape r22200 the extension 'Guides Creator' no longer works, whereas in my last build r22179 it still works without error message (I tested with fresh preferences.xml each). Could this be related to your patch (I know that the 'guides_creator.*' files themselves have not been touched since rev 21146)?

Error message:

Usage: guides_creator.py [options] SVGfile

guides_creator.py: error: no such option: --preset

Revision history for this message
su_v (suv-lp) wrote :

Sorry - I must have made a mistake with some modified launcher script files - using the original versions the extension works as expected...

Revision history for this message
su_v (suv-lp) wrote :

Wrong again - but solved: the problem was that I have a newer version of the 'Guides Creator' (2.31) in ~/.config/inkscape/extensions installed, and while I had renamed and modified that inx file to use a separate menu entry I forgot to rename 'guides_creator.py' as well to be able to use both versions in parallel. So the original inx file called the newer version of the python script instead and failed due to changes in the script options.

Revision history for this message
jazzynico (jazzynico) wrote :

Another patch for the following new typos:

1. share/extensions/draw_from_triangle.inx.h:35 (in the long description)
"an formula" -- a
2. share/extensions/draw_from_triangle.inx.h:
"a circle about a custom point" -- around
3. share/extensions/polyhedron_3d.py:
msgid ""
"Failed to import the numpy module. This module is required by this "
"extension. Please install it and try again. On a Debian-like system this "
"can be done with the command, sudo apt-get install python-numpy."
 -- would be better if the command was between quote marks, and without the comma.

Also added a revert for a bad fix in the previous patch (incorrect disambiguation in INX files, "Top" is now disambiguated in layers.cpp - Bug #426703) and a new string added to translation files (the default "filter" string for a new filter in the editor is now translatable).

Changed in inkscape:
status: Fix Released → In Progress
Revision history for this message
jazzynico (jazzynico) wrote :

Patch committed in rev. 22248.

Changed in inkscape:
importance: Undecided → Low
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.