Comment 5 for bug 404941

Revision history for this message
Diederik van Lierop (mail-diedenrezi) wrote :

I haven't applied this patch yet, because I'm not fully sure that it won't affect other parts in the code. The member variables that are being affected here are also used for example for updating the handles, although I haven't seen any evidence yet of things going wrong. I'm just being careful not to screw up this close before the new release. One way to handle this would be to add another member variable specifically for translations, but this would require some changes downstream in the code because we now have two member variables that need to be handled. For example, what should we then do with the setting of the snapindicator, some lines further down in the grab() method? We cannot tell here yet whether we're translating or not, so we cannot decide where to put the snap indicator. Anyway, this is just to let you know that I haven't forgotten your patch.

Something else I just realized is that when snapping the bbox with your patch applied, only the grabbed item is being considered,
whereas when snapping the nodes still all selected items are being considered. Shouldn't we just use all four bbox corners of each selected item, instead of only the grabbed item? This way you can still snap the bbox corners of the grabbed item instead of the four corners of the bbox of the selection, just as you intended to with your patch. This makes bbox snapping consistent to node snapping (although only for translations).