Invert doesnt work on objects with gradients.

[dopelover]

Right-clicking on fill and stroke widget in lower right corner of main window, and then selecting Invert from popuped menu doesn't work when selected object has a gradient fill or gradient stroke.

Inkscape r21234 on Ubuntu 9.04

[jazzynico (jazzynico)]

Confirmed on Ubuntu 9.04, build 21237.
I don't think it ever worked (I also tried with 0.46), so I mark it Wishlist. Can anyone confirm?

[John Smith (john-smithi)]

Should be fixed by trunk commit r11694.

[su_v (suv-lp)]

Hmm, this is an odd fix AFAIU: 'Invert' from context menu of the current fill/stroke swatch in the status bar _reverts_ the direction of the gradient instead of inverting the color(s) as is done for normal flat colors.

[John Smith (john-smithi)]

Yes, i agree the language is a little odd.
But if you press the "Reverse the gradient direction" from the gradient toolbar, or use <Shift>+r from the gradient tool, then you see "Invert gradient" in Undo history. The words "reverse" and "invert" are both used for the same thing.

So currently "Invert" from the selected style bottom status bar context menu:
* When a stop is selected and then stops color is inverted.
* If no stops are selected then the gradient is "inverted" (or reversed).

What do you think should happen when no stop is selected ?

[ScislaC (scislac)]

I think a distinction can be made... inverting a gradient is reversing (it makes sense English-wise)... but a new "invert gradient color(s)" function is sensible on no selection imho.

[su_v (suv-lp)]

> Yes, i agree the language is a little odd. But if you press the
> "Reverse the gradient direction" from the gradient toolbar, or use
> <Shift>+r from the gradient tool, then you see "Invert gradient" in
> Undo history.

I didn't look at the undo history TBH. My spontaneous reaction was: reverting a gradient is not the same as inverting colors.

> What do you think should happen when no stop is selected ?

My personal expectation would be that the colors of all stops are inverted.

For reversing the gradient direction, I'd be looking for a separate menu entry (if at all present in that context menu).

[su_v (suv-lp)]

Some new warnings when compiling r11694 and later… :
  CXX gradient-chemistry.o
../../src/gradient-chemistry.cpp: In function ‘SPGradient* getGradient(SPItem*, Inkscape::PaintTarget)’:
../../src/gradient-chemistry.cpp:568: warning: enumeration value ‘FOR_FILL_AND_STROKE’ not handled in switch
  CXX gradient-drag.o
../../src/gradient-drag.cpp: In member function ‘SPObject* GrDraggable::getServer()’:
../../src/gradient-drag.cpp:724: warning: enumeration value ‘FOR_FILL_AND_STROKE’ not handled in switch

[John Smith (john-smithi)]

r11696 should invert the colors of all stops if no stop is selected.
Also changes the Undo history to "Reverse gradient" when reversing a gradient.