Aligning nodes is "swapped" [svn]

[Damiano Dallatana]

I am using Inkscape from svn, and I did find out that aligning nodes icons are swapped

Steps to reproduce:
1. select a path
2. select two or more nodes on the path
3. open the alignment window
4. align the nodes horizontally (vertically)

Expected result: the nodes become aligned horizontally (vertically)
What happens: the nodes are aligned vertically (horizzontally): the two buttons are "swapped".

The problem is that /trunk/share/icons/hicolor/scalable/actions/align-horizontal-nodes.svg is for vertical alignment, and /trunk/share/icons/hicolor/scalable/actions/align-vertical-nodes.svg is for orizontal alignment. Renaming the icons solves the bug.

[RIco (rico-rootscore-deactivatedaccount)]

it was supposed to be fixed in svn r20931 by tweenk.... but i don't see any change, i still get the swapped behaviour.

[RIco (rico-rootscore-deactivatedaccount)]

this is a simple fix ... can somebody please swap the names of the icons in svn to get it to build correctly?

thanx

[Halley (ed-halley)]

I'm not sure the icons are the problem. Ignoring the hicolor/scaleable files, the original button graphics in icons.svg file have the right ID but the wrong label for these two buttons. The code seems to agree with the ID values. The orientation that is assigned in the addNodeAction() seems to be wrong. I can commit changes to align-and-distribute dialog.

[Halley (ed-halley)]

However, looking again, the icon images are in swapped positions from 0.46 ordering. Which means the ID names (and hicolor filenames) are swapped from their intended meanings. Bleh.

[RIco (rico-rootscore-deactivatedaccount)]

fixed in svn r21038

[Halley (ed-halley)]

Reverted the quick fix (Geom::X and Geom::Y in align-and-distribute.cpp) and swapped the icon names (as Rico originally stated on 2009-03-24). Swapped ID values in icons.svg and also the hicolor filenames. Now matches 0.46 ordering and behavior. Sorry for the confusion. svn r21062