parseColor() in simplestyle.py can't parse colors of type rgb(xx.x%,xx.x%,xx.xx%)

[Kjell Magne Fauske]

The parseColor() function in simplestyle.py can't parse valid color expressions like:

parseColor('rgb(66.667%,0%,6.667%)')
parseColor('currentColor')
parsecolor('ActiveBorder')

I have attached a patch that fixes the first problem. I have also attached unit tests that verifies it.

For the two other color types there is no straightforward solution since resolving the color code requires knowledge of the environment. A workaround is to return a default color, but it is not an ideal solution.

[Kjell Magne Fauske (kjellmf)]

I have attached a patch that return a default color (black) in cases where the color is unknown. Not sure if this is the best approach, but it is probably better than raising an exception.

[jazzynico (jazzynico)]

Fix committed in the trunk, revision 10610.
Thanks for the patches and the test file (committed as well in the test directory).

As you noticed in the bug description, currentColor and ActiveBorder are very difficult to parse here. I'm going to close the reoort because it fixes what can be fixed with numerical values. Feel free to open a different report for the remaining issues.

[jazzynico (jazzynico)]

Back-ported to the 0.48.x branch, revision 9830.