Patch to eliminate NRPoint and NRMatrix in favour of NR::*
Bug #203318 reported by
Jaspervdg
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Inkscape |
Fix Released
|
Undecided
|
Unassigned |
Bug Description
This patch eliminates NRPoint and NRMatrix in favour of NR::Point and NR::Matrix (and friends).
A follow-up patch to eliminate NR::Point and NR::Matrix in favour of 2geom classes would be very nice (and if time permits I'll probably write one).
BTW, it does not (yet) eliminate overloads of functions for NR(::)Matrix* instead of NR::Matrix & (functions that were defined for both still are, except that the NRMatrix* is now an NR::Matrix*).
To post a comment you must log in.
Hi Jasper,
I think nobody is going to review a 162kb patch.
Do you have anything in particular you're uncertain about? Otherwise I think you should just commit it.
Thanks for your work!