Patch to eliminate NRPoint and NRMatrix in favour of NR::*

Bug #203318 reported by Jaspervdg
2
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Undecided
Unassigned

Bug Description

This patch eliminates NRPoint and NRMatrix in favour of NR::Point and NR::Matrix (and friends).

A follow-up patch to eliminate NR::Point and NR::Matrix in favour of 2geom classes would be very nice (and if time permits I'll probably write one).

BTW, it does not (yet) eliminate overloads of functions for NR(::)Matrix* instead of NR::Matrix & (functions that were defined for both still are, except that the NRMatrix* is now an NR::Matrix*).

Revision history for this message
Jaspervdg (jaspervdg) wrote :
Revision history for this message
Johan Engelen (johanengelen) wrote :

Hi Jasper,

I think nobody is going to review a 162kb patch.
Do you have anything in particular you're uncertain about? Otherwise I think you should just commit it.

Thanks for your work!

Revision history for this message
Jaspervdg (jaspervdg) wrote :

Johan, I guess you're right that reviewing such a big patch isn't much fun, so I went ahead and committed the patch. It should be fine, as I did double-check it myself and it mostly consists of search/replace-like changes.

Revision history for this message
Diederik van Lierop (mail-diedenrezi) wrote :

No one complained, so I guess this one can be closed ;-)

Changed in inkscape:
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.