Split msgid "Text" for menu Effects

Bug #187587 reported by Marcin Floryan
4
Affects Status Importance Assigned to Milestone
Inkscape
Fix Released
Low
jazzynico

Bug Description

For the sake Polish translation it would be useful if the "Text" menu item under "Effects" could be a separate msgid.

Ryan Lerch (ryanlerch)
Changed in inkscape:
status: New → Incomplete
Revision history for this message
Alexandre Prokoudine (alexandre-prokoudine) wrote :

The issue is clear indeed. I'll try giving it a shot, because more messages like this need a context, but since I'm not experienced at that, I make no promises.

Changed in inkscape:
importance: Undecided → High
milestone: none → 0.46
status: Incomplete → Confirmed
Revision history for this message
Marcin Floryan (mfloryan) wrote :

OK. I have digged through the code a bit this weekend and will have some diffs shortly to address this issue.

Revision history for this message
Bryce Harrington (bryce) wrote :

Hi Marcin, if you've had a chance to produce some diffs, could you upload them to this bug report? We're running short on time and need to reach a decision on this bug with regard to 0.46.

Revision history for this message
Marcin Floryan (mfloryan) wrote :

Sorry. We can leave it as is for now. We could re-address this issue with further releases if it was still a problem. Currently the Polish translation has been altered to cater for this.

Luca Bruno (lucab)
Changed in inkscape:
milestone: 0.46 → none
Revision history for this message
Marcin Floryan (mfloryan) wrote :

Bryce, some guidance on the menu structure would be appreciated. So far I just found a reference to menus.xml (but no such file). I assume currently verbs are used to create menu items and for the two occurrences of the "Text" in the menu the same verb is used but this is just a wild guess.

Revision history for this message
Bryce Harrington (bryce) wrote :

Marcin, thanks for indicating this can be addressed later on after 0.46.

I think what you're looking for is in inkscape/share/ui/. There is also some documentation to introduce how tgo add verbs available at http://wiki.inkscape.org/wiki/index.php/AddingInterfaceVerbs you might be interested in.

Revision history for this message
Marcin Floryan (mfloryan) wrote :

Looking through the code the bug can be solved in a fairly simple way but would require the use of Q() instead of _() for all Extensions and would require changes to all text-related extensions. While I am comfortable with the latter I am not sure if the former would not be too much of an overhead.

Changed in inkscape:
assignee: nobody → mfloryan
jazzynico (jazzynico)
tags: added: translation
jazzynico (jazzynico)
tags: added: i18n
Revision history for this message
jazzynico (jazzynico) wrote :

@Marcin, I'm currently working on implementing gettext context for INX files. Do you mind if I assign myself to this bug?

Revision history for this message
jazzynico (jazzynico) wrote :

INX context now works in the trunk, but only for elements values. intltool doesn't seem to support context for the attributes, and thus fixing the issue can be only achieved by adding a context to the cpp code strings.

Changed in inkscape:
assignee: Marcin Floryan (mfloryan) → JazzyNico (jazzynico)
milestone: none → 0.49
status: Confirmed → Triaged
importance: High → Low
jazzynico (jazzynico)
Changed in inkscape:
status: Triaged → In Progress
Revision history for this message
jazzynico (jazzynico) wrote :

Fix committed trunk revision 11606.

Changed in inkscape:
status: In Progress → Fix Committed
jazzynico (jazzynico)
Changed in inkscape:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.