Grid details in Document Properties don't show up after 'redo'

[Maximilian Albert]

(SVN rev. #17189 on Debian unstable)

Steps to reproduce:

1) Start Inkscape
2) Open the Document Properties dialog with page "Grids"
3) Click on "New" so that a grid is created (any will do)
4) Remove the grid again by pressing the "Remove" button
     --> this correctly empties the "Defined grids" section
5) Hit Ctrl+Z ('undo') twice. This undoes the deletion and creation of the grid.
6) Hit Ctrl+Y ('redo')

The last step redoes the grid creation, *but the grid details do not appear in the dialog* (this is the bug).

In the source code, line #389 in ui/dialog/document-properties.cpp checks whether the grid already has an ID, and there is a comment saying that the function update_gridspage() is called again when this ID is added. It seems that this is true in most cases but not for the 'redo' step described above so that the rest of update_gridspage() is skipped in this case.

[Bryce Harrington (bryce)]

Confirmed with svn head from today.

[su_v (suv-lp)]

Could the crash reported in bug #237863 be related to this 'undo/redo' bug?

console message:
ERROR:xml/simple-document.cpp:48:virtual Inkscape::XML::Event* Inkscape::XML::SimpleDocument::commitUndoable(): assertion failed: (_in_transaction)

The crash when toggling "Live preview" in the extension dialog can be consistently reproduced by opening the properties dialog with page "Grids" (and - if none exists - adding a new grid) first before toggling the extension preview.
<https://bugs.launchpad.net/inkscape/+bug/237863>

backtrace with Inkscape 0.46+devel r22547 on OS X 10.5.8:
<http://launchpadlibrarian.net/34938723/LivePreviewToggle_backtrace_from_crash-report_Inkscape-r22547.txt>

[Beluga (buovjaga)]

Still repro.

Arch Linux 64-bit, KDE Plasma 5
Inkscape 0.91 r13725

[Jonathan Hofinger (jhofinger)]

Hi - thanks for reporting this bug, I've manually migrated it to Inkscape's new bug tracker on GitLab, and closed it here.

Please feel free to file new bugs about the issues you're seeing at http://inkscape.org/report.

Moved to: https://gitlab.com/inkscape/inbox/issues/2193
Closed by: https://gitlab.com/jhofinger