Color "Book" widget needs refactoring

Bug #1809522 reported by Roman Hargrave
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Invalid
Undecided
Unassigned

Bug Description

The engineering of the color book widget (the color picker) is such that making changes, repairs, and additions is a complicated process. Much of this is a result of the logic for each color system being completely un-encapsulated.

Where each page of the booklet could implement a class and internalize functionality such as updating sliders and calculated color, each system is implemented as a branch in a function.

Encapsulating color system logic could potentially make it less time consuming to fix issues such as the CMYK, HSL, and HSV sliders "slipping" when adjusted (as a result of their values being derived from RGB - CMYK is a particularly big offender here), or color swatches not updating to reflect values entered in the spinners, rather than the sliders.

Revision history for this message
grey tomorrow (gtomorrow) wrote :

Closing because INVALID.

If you feel this issue has been injustly closed, please feel free to open a new issue at http://inkscape.org/report . Thank you.

Closed by: https://gitlab.com/greytomorrow

tags: added: bug-migration
Changed in inkscape:
status: New → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.