In commit dcd8ad25023db542ade5edc23fc5f943d8ee6376 poppler marked as deleted Object::dictAdd.
As a result inkscape-0.92.3 does not compile anymore
commit dcd8ad25023db542ade5edc23fc5f943d8ee6376
Author: Albert Astals Cid <email address hidden>
Date: Thu Aug 23 23:07:41 2018 +0200
Also delete Object::dictAdd that takes a char *
Makes sure noone gets a char * -> const char * promotion via Object
ERROR message:
In file included from /usr/include/gtk-2.0/gtk/gtk.h:173,
from /usr/include/gtkmm-2.4/gtkmm/box.h:44,
from extension/internal/grid.cpp:18:
/usr/include/gtk-2.0/gtk/gtkstatusicon.h:76:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved1’ [-Wparentheses]
void (*__gtk_reserved1);
^
/usr/include/gtk-2.0/gtk/gtkstatusicon.h:77:8: warning: unnecessary parentheses in declaration of ‘__gtk_reserved2’ [-Wparentheses]
void (*__gtk_reserved2);
^
extension/internal/pdfinput/pdf-parser.cpp: In member function ‘Stream* PdfParser::buildImageStream()’:
extension/internal/pdfinput/pdf-parser.cpp:3689:39: error: use of deleted function ‘void Object::dictAdd(char*, Object&&)’
dict.dictAdd(key, std::move(obj));
^
In file included from /usr/include/poppler/GfxState.h:43,
from /usr/include/poppler/Gfx.h:42,
from extension/internal/pdfinput/pdf-parser.cpp:35:
/usr/include/poppler/Object.h:267:8: note: declared here
void dictAdd(char *key, Object &&val) = delete;
^~~~~~~
Seriously poppler should consider having a deprecation period, we already have way too many #if for poppler stuff.
They can't just go from
void dictAdd(const char *key, Object &&val);
to
void dictAdd(char *key, Object &&val) = delete;
void dictAdd(const char *key, Object &&val);
and just expect everyone to #if all uses of it ?