0.92.x: Extensions use previous selection when nothing is selected

[Hachmann]

I was surprised to notice that self.selected.iteritems returns the previous selection that has been used with an extension, if nothing is selected.

To reproduce:

- draw a couple of paths with pencil tool
- select one of them
- run Visualize Path > Measure path
- deselect object
- run Visualize Path > Draw handles

Expected result:

 Extension tells me that there is no selection.

Actual result:

 The extension draws handles on the path I had selected for use with the previous extension.

Should a variable be unset somewhere in the C++ code after an extension has finished running?

This is with Inkscape 0.92.3 (b1b3369, 2018-06-06) on Linux Mint 18.3.
Same for master, 0.92+devel (e4a9aed, 2018-06-18).

[Alvin Penner (apenner)]

interesting, must be recent:
- reproduced on Windows 10, Inkscape 0.92.3 (b1b3369, 2018-06-06)
- not reproduced on Windows 10, Inkscape 0.92.3 (2405546, 2018-03-11)

[Hachmann (marenhachmann)]

Thanks for testing, Alvin!

[Alvin Penner (apenner)]

narrowed it down a bit more:

- not reproduced on Windows 10, Inkscape 0.92.3 (10e8ae0, 2018-05-25)
- reproduced on Windows 10, Inkscape 0.92.3 (b1b3369, 2018-06-06)

possibly related to this commit:
https://gitlab.com/inkscape/inkscape/commit/b1b33698810bb8ae6e31e509697ff27d2732e7ac

[Hachmann (marenhachmann)]

Good work :) In case you hadn't pinged Jabier yet, I did (on the commit on gitlab).

[Jabiertxof (jabiertxof)]

Try to fix tomorrow, thanks for the ping Maren

⁣Enviado desde TypeApp ​

En 19 jun. 2018 23:01, en 23:01, Hachmann <email address hidden> escribió:
>Good work :) In case you hadn't pinged Jabier yet, I did (on the commit
>on gitlab).
>
>--
>You received this bug notification because you are subscribed to
>Inkscape.
>Matching subscriptions: Inkscape
>https://bugs.launchpad.net/bugs/1777530
>
>Title:
> 0.92.x: Extensions use previous selection when nothing is selected
>
>Status in Inkscape:
> Confirmed
>
>Bug description:
> I was surprised to notice that self.selected.iteritems returns the
> previous selection that has been used with an extension, if nothing is
> selected.
>
> To reproduce:
>
> - draw a couple of paths with pencil tool
> - select one of them
> - run Visualize Path > Measure path
> - deselect object
> - run Visualize Path > Draw handles
>
> Expected result:
>
>  Extension tells me that there is no selection.
>
> Actual result:
>
>  The extension draws handles on the path I had selected for use with
> the previous extension.
>
> Should a variable be unset somewhere in the C++ code after an
> extension has finished running?
>
> This is with Inkscape 0.92.3 (b1b3369, 2018-06-06) on Linux Mint 18.3.
> Same for master, 0.92+devel (e4a9aed, 2018-06-18).
>
>To manage notifications about this bug go to:
>https://bugs.launchpad.net/inkscape/+bug/1777530/+subscriptions

[Hachmann (marenhachmann)]

Jabier, that would be cool :)

[Jabiertxof (jabiertxof)]

Fixed in master in e33f40d66476a27daec0153ef764a01733935df9
and in 0.92.x in cdafc079a93b6d26750948bb324f1130433163a8

Thanks for fill the bug!

[Hachmann (marenhachmann)]

Supercool - thanks Jabier! I love that it no longer deselects the object after the extension has run! (which is probably the change that had caused the problem).

Can I add that info to the release notes for 0.92.4?

[Jabiertxof (jabiertxof)]

Great, you also can speak about performance on apply multiple filters or using a complex doc.
Regards.

[Hachmann (marenhachmann)]

@Jabiertxof Can you tell me a bit more about the performance improvements? Do they have anything to do with extensions? Or is this about rendering / the objects dialog /...?