Inkscape 0.92.3 won't compile with poppler 0.65

Bug #1772883 reported by Konrad Rzepecki on 2018-05-23
38
This bug affects 7 people
Affects Status Importance Assigned to Milestone
Inkscape
Critical
Jan Palus
inkscape (Linux From Scratch)
New
Undecided
Unassigned

Bug Description

Compiling stops on missing GooHash.h header file:

make[3]: Entering directory '/tmp/SBo/inkscape-0.92.3/src'
  CXX extension/internal/pdfinput/pdf-parser.o
extension/internal/pdfinput/pdf-parser.cpp:41:10: fatal error: goo/GooHash.h: No such file or directory
 #include "goo/GooHash.h"
          ^~~~~~~~~~~~~~~
compilation terminated.

This missing header was removed in poppler 0.65.

same problem on macOS High Sierra - can't find any mention of this elsewhere.

affects: lfs → inkscape (Linux From Scratch)
Patrick Storz (ede123) wrote :

Thanks for the report.

We should try to investigate and fix this soon. Any help is welcome!

Changed in inkscape:
status: New → Confirmed
importance: Undecided → Critical
Jan Palus (jan-palus) wrote :

After a closer look it appears fix is actually trivial -- mentioned header file GooHash.h is not used in this file, same goes for another header GooTimer.h. On the other hand pdf -parser.cpp uses GooString for which header file is missing. Attached patch fixes above issues.

Konrad Rzepecki (labinnah) wrote :

I can confirm that this patch fixes the problem.

Thanks!

Mc (mc...) wrote :
Changed in inkscape:
assignee: nobody → Jan Palus (jan-palus)
milestone: none → 0.92.3
status: Confirmed → Fix Committed
Patrick Storz (ede123) wrote :

Thanks for merging Mc, just wanted to look into this myself.

Changed in inkscape:
milestone: 0.92.3 → 0.92.4
John Talbot (ztalbot2000) wrote :

May I also add that if you are compiling for OSX, you will also need this patch as well:

https://gitlab.com/inkscape/inkscape/commit/fa1c469aa8c005e07bb8676d72af9f7c16fae3e0

To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers