Inkscape 0.92.3 won't compile with poppler 0.65

[Konrad Rzepecki]

Compiling stops on missing GooHash.h header file:

make[3]: Entering directory '/tmp/SBo/inkscape-0.92.3/src'
  CXX extension/internal/pdfinput/pdf-parser.o
extension/internal/pdfinput/pdf-parser.cpp:41:10: fatal error: goo/GooHash.h: No such file or directory
 #include "goo/GooHash.h"
          ^~~~~~~~~~~~~~~
compilation terminated.

This missing header was removed in poppler 0.65.

[Thomas Prellberg (thomasprellberg)]

same problem on macOS High Sierra - can't find any mention of this elsewhere.

[Patrick Storz (ede123)]

Thanks for the report.

We should try to investigate and fix this soon. Any help is welcome!

[Jan Palus (jan-palus)]

After a closer look it appears fix is actually trivial -- mentioned header file GooHash.h is not used in this file, same goes for another header GooTimer.h. On the other hand pdf -parser.cpp uses GooString for which header file is missing. Attached patch fixes above issues.

[Konrad Rzepecki (labinnah)]

I can confirm that this patch fixes the problem.

Thanks!

[Mc (mc...)]

Thanks for the patch !!

pushed to https://gitlab.com/inkscape/inkscape/commit/fa1c469aa8c005e07bb8676d72af9f7c16fae3e0 and https://gitlab.com/inkscape/inkscape/commit/10e8ae0ff522d3a9caeed9a7f137cdfd795ba0a3

[Patrick Storz (ede123)]

Thanks for merging Mc, just wanted to look into this myself.

[John Talbot (ztalbot2000)]

May I also add that if you are compiling for OSX, you will also need this patch as well:

https://gitlab.com/inkscape/inkscape/commit/fa1c469aa8c005e07bb8676d72af9f7c16fae3e0