Grid settings not respected when reopening document

[JiHO]

Settings regarding grid spacing are not respected when reopening documents:
- on old documents (before the new grid code with axonometric gris and all) the grid is always shown even if it was hidden in the document previously
- on new documents, the unit is always set back to px and x grid spacing is always set back to 1px.

In addition, some old grid settings are still present:
     showgrid="false"
     gridspacingx="2mm"
     gridspacingy="2mm"
along side the new ones:
    <inkscape:grid
       type="xygrid"
       id="grid6859"
       originx="0px"
       originy="0px"
       spacingx="1px"
       spacingy="1px"
       units="px"
       empspacing="5" />
but are not kept in sync. Either they need to be removed or they need to be kept in sync to ensure compatibility with older versions (the first choice would be OK for me, Inkscape is free and <1.0 so it's not difficult to upgrade and there's a tacit understanding that things are still likely to change).

Tested on r16565 but the bug has been present for a few revisions (at least since 16527).

[JiHO (jiho)]

Does not occur with older rev 16467.

[JiHO (jiho)]

On 2007-December-08 , at 14:42 , hash wrote:
> ** Changed in: inkscape
> Status: New => Incomplete

What's incomplete about the bug description?

JiHO
---
http://jo.irisson.free.fr/

[hash (hash-g)]

Needed to see myself, the most recent win32 build Inkscape0712071739, has it too.

[Johan Engelen (johanengelen)]

After quite some work, fixed in svn rev. 16863
It reads the old grid settings strings, and puts them in a new-style XY grid definition. Not tested extensively.

[nightrow (jb-benoit)]

I'm sorry to say i still have this behavior on last SVN Inkscape0801160334.7z.
I set a 10*10 grid and when i reopen the document the grid is 0*0.
Can't join document because i can't publish it but i'll try to make a demonstration one later today.

[Johan Engelen (johanengelen)]

This was actually a different bug, concerning pre0.46 inkscape files. But it has already been fixed. Can you test again? Set to fixed if so.

 It was caused because of recoding the widgets (RegisteredWidget to RegisteredWidget<E>), but I just fixed it.

[nightrow (jb-benoit)]

I confirm that i don't have this bug anymore on the 0.46pre0 version with my
bugguy file.
This is thus indeed solved for me.

On Jan 23, 2008 5:59 PM, Johan Engelen <email address hidden> wrote:

> ** Changed in: inkscape
> Status: Incomplete => Fix Released
>
> --
> Grid settings not respected when reopening document
> https://bugs.launchpad.net/bugs/172778
> You received this bug notification because you are a member of Inkscape
> Bug Team, which is the bug contact for Inkscape.
>

[Mike Kowalski (mike-kov)]

I use a nightly build (Jan 28, 2008) and there's still a problem with restoring grid lines transparency. If I open a doc with grid transparency different than defined in a default template, those settings will only be used after opening document properties dialog box.

[Bryce Harrington (bryce)]

Reopening as per user comment

[Mike Kowalski (mike-kov)]

I tried hard to reproduce this problem again to provide exact steps, and I couldn't.
When I encountered it for the first time, I opened document properties, clicked on a checked "Visible" checkbox in a grid tab, and blue grid lines turned lighter. I don't know if was the effect of redrawing grid lines in document settings (reduced opacity), or drawing them just once (can they be drawn twice by mistake?).
At any rate, I encountered different problem with "Show grid" command having no effect on grid visibility.
Let me know which source file to scrutinize, I suspect something's still not quite right...

[Johan Engelen (johanengelen)]

I am also experiencing buggy behavior, but do not know the exact steps to reproduce.
Often it gets 'fixed' when opening the document properties dialog.

> Let me know which source file to scrutinize, I suspect
> something's still not quite right...

Related files:
- src/display/canvas-grid.cpp
this *should* do all loading of XY grid variables from svg, and initialize the grid accordingly)

- src/ui/dialogs/document-properties.cpp
(this apparantly triggers some reloading or initialization of grid variables...)

- src/sp-namedview.cpp
The function 'sp_namedview_generate_old_grid' reads old 0.45 grid values and generates a new grid from them. It deletes the old values afterwards. Don't think this file matters.

Thanks for looking into this.

[David Császár (p5)]

can reproduce this with Inkscape 0.45.1+0.46pre1+devel, built Feb 1 2008 and the attached file. (on win xp)
1. save the file
2. click it
->wrong grid (dark blue)
3. select file->document settings
->correct grid (light blue & light red)

[Diederik van Lierop (mail-diedenrezi)]

Same here:
1) starting inkscape
2) opening a document with a grid, using "Open recent"
3) the default grid is being displayed, not the grid as set in the document
4) after opening the document properties dialog: the correct grid parameters are being loaded and the grid is updated

[Johan Engelen (johanengelen)]

working on it (waiting for build). simple bug :) indeed the actual parameters were read during widget creation, instead of during grid creation... d0h!