Comment 14 for bug 172133

Revision history for this message
David Mathog (mathog) wrote :

The attached patch implements display of text decorations. It does not implement setting them within Inkscape - they must already be present in the SVG. Maybe they will "take" if the XML is edited, but that has not been tested extensively.

Known issues:

1. Some fonts, for whatever reason, cause the text decoration to not be set in the style. On my Linux box "Courier New" does this. When this happens selecting the text and changing to another font, like "Arial", causes the decorations to appear. Since the patch doesn't even look at font names this issue was probably present in the code before, just not visible because no text decorations were present.

2. Some bits and pieces of the next generation SVG text decoration have been edited in, since I was in there anyway, but none of that has been fully implemented yet. So no dots, dashes, wavy lines, or colors (different from the text) yet.

3. Currently "Blink" is drawn as a double strikethrough. It was a toss up for me between showing that the decoration was set and just ignoring it. At least while this is still experimental I think it is better to show some indication when that is on. Perhaps better to not show anything when it is off.

4. What does "_drawing.outline()" do in _renderItem in drawing-text.cpp? I did not have any SVG that triggered it. If it is set
the decorations will not be shown since that case has its own return. If somebody sends me an example I will fix this.

Examples with text decoration and the font bug will be posted next.