Memory access error (crash) on undo of Pattern along Path

[Stephen Michael Gombas]

Upon updating to 0.92.2, I found that if I use the ellipse shape on the bezier tool, then move the shape with the node editor tool, then try to undo the path, Inkscape immediately crashes without fail. When I open the autosave file it creates upon crashing and click on the line that was there with the node selector tool, it crashes again. It has to be selected with the object selector tool and deleted to not crash. This has been reproduced by two others on windows, and once on Linux Mint 18.2. This bug appears on a fresh install as well.

To better exemplify what how this bug behaves, I've made a video. It shows the original crash, me trying to click on it, and then I recreate the bug again. I then show you my resource allocation for inkscape, system specs, and inkscape version.

https://www.youtube.com/watch?v=YE-ahcmeAFY

Windows 10 Home 64x
Inkscape 0.92.2 - 8 threads, 4096 MB RAM allocated

[Jabiertxof (jabiertxof)]

Fixed in trunk in r.58ef38f81c

[Jabiertxof (jabiertxof)]

Fixed in 0.92.x in r.194e3ff648

[Jabiertxof (jabiertxof)]

Thanks for fill the bug @tubahorse

[Stephen Michael Gombas (tubahorse)]

Excellent! Does this mean it's fixed? Where can I download the fixed version?

[Patrick Storz (ede123)]

Both issue and fix confirmed.

@Jabiertxof: Thanks for the fix!
One other thing (not meant to blame, just a suggestion on how to achieve clearer commit messages others can use more efficiently):

You put "Fixes for bug #1716926. Consider backport".
- For the "Consider backport" part:
  We have the "backport-proposed" tag in Launchpad, so you can omit
  it from the commit message (were it does not belong and is likely
  to be overlooked anyway; certainly it's not suitable to track
  commits that should be considered for backporting reliably)
- For the "Fixes for bug #1716926." part:
  While this additional information is helpful and should be part
  of the commit message it does not really describe what your
  commit was about (unless one digs through the bug itself which
  is tedious and often impractical, e.g. while preparing release
  notes).
  I suggest you put a very short (but very precise) summary of the
  commit into the first line of the commit message, e.g.
  "Fix crash when removing a path with ellipse shape via undo"
  in this case.

[Jabiertxof (jabiertxof)]

Thanks @eduard-braun2 I do as it in the future!

[Jabiertxof (jabiertxof)]

There is only source code to compile it @tubahorse.

The code for the next release "0.92.3" is in the git branch "0.92.x" on our Inkscape repository over gitlab.
https://gitlab.com/inkscape/inkscape

Cheers, Jabier.

[Stephen Michael Gombas (tubahorse)]

My mistake! Again, thank you for fixing this bug @jabiertxof.

[Patrick Storz (ede123)]

Actually we have CI builds available for Windows!

At [1] you'll find the latest builds, the one for Jabier's commit would be [2].
If you follow one of the links (MINGW32 for 32-bit build, MINGW32 for the 64-bit build) you can download a complete package (7-zip archive) from the "Artifacts" tab.

I admit it's a bit hidden but should work flawlessly.

[1] https://ci.appveyor.com/project/inkscape/inkscape/history
[2] https://ci.appveyor.com/project/inkscape/inkscape/build/0.92.x-482

[Jabiertxof (jabiertxof)]

you are welcome @tubahorse

[Stephen Michael Gombas (tubahorse)]

Hello! I see 0.92.3 has been released. Was this bug fixed in the update?