sqrt optimization patch

Bug #1716286 reported by Codain
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Inkscape
Invalid
Undecided
Codain

Bug Description

Looking at the source code here is a patch which reduce the number of sqrt calls in some specific cases:
* Use of for/while loops with sqrt on constants data
* Use of the square root of a constant multiple times

+ some floating point divisions enhancements.

Revision history for this message
Codain (codain) wrote :
Changed in inkscape:
assignee: nobody → Romain (romain2boss)
Revision history for this message
Mc (mc...) wrote :

Hi,

can you make a MR on gitlab with your changes ?
Also, there are a few tabs to get rid of, and I'm not sure I see the advantage of the
- something = stuff * ((a+b)/2)
+ mean = (a+b)/2
+ something= stuff*mean

or of the added dots in 2 → 2.

Thanks

Revision history for this message
Qantas94Heavy (qantas94heavy) wrote :

Closing as this has not had any response for over a year. If you still want your changes to be included, please create a merge request on GitLab: https://gitlab.com/inkscape/inkscape/merge_requests. Thanks!

Closed by: https://gitlab.com/Qantas94Heavy

Changed in inkscape:
status: New → Invalid
tbnorth (terry-n-brown)
tags: added: bug-migration
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.