Missing icon breaks Image Properties : no longer brings up Object Attributes dialogue

[Christopher M. Rogers]

Right-Click an image > Image Properties does nothing.
It should bring up the Object Properties Dialog.

The reason it doesn't is because of a missing icon "dialog-object-attributes.svg"

A current work-around is to copy one of the existing icons to take its place:

cd /usr/share/inkscape/icons/
cp dialog-object-properties.svg dialog-object-attributes.svg

[Christopher M. Rogers (cajhne)]

According to su_v on #inkscape-devel:

"It's clearly a "regression" (or unsolved or unfinished issue) introduced with the switch to GTK+ icon theme only during the hack fest
that dialog likely uses a custom routine to load the icon (that's likely also the reason that icon can't be rethemed e.g. with a gtk symbolic icon)
(none of the icons for dockable dialog can, IIRC - forgot about that detail)
either inkscape, or gdl"

[su_v (suv-lp)]

/me contd on #inkscape-devel:

> alternative fix: remove the reference to the non-existing (it never
> was added to icons.svg) icon name of the verb (in src/verbs.cpp)
> https://gist.github.com/su-v/7a9d9322bfc32c1ff2f148bbb93ed21a
> either way - both workarounds are not recommended to be committed as
> is - they simply hide the underlying issue (but at least allow to
> work with trunk builds)

[Tavmjong Bah (tavmjong-free)]

Interesting... it works in a not too old version of master. Something else must have changed since the hackfest.

The icon "dialog-object-attributes" does not exist in 0.48, 0.91. 0.92, or master. The quickest fix is to change the code to refer to "dialog-object-properties". I've done this.