Xaml export misses some radialGradients

Bug #1695016 reported by Mathieu GRENET on 2017-06-01
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mathieu GRENET
Mathieu GRENET

Bug Description

a typo in svg2xaml.xsl prevent radial gradients to be converted.

I attached un example svg file with a patch (generated with winmerge I don't know if it is ok)

Inkscape 0.92.1 r15371

Mathieu GRENET (mgth) wrote :
jazzynico (jazzynico) wrote :

Thanks for the patch! We usually use an unified diff format, but don't worry, your file is perfectly usable, and it's great you took some time to investigate and find a fix!

I'll try to test it a bit later. If everything is ok (and as the patch is pretty straightforward, I'd say there's no reason to not accept it), it will be included in 0.93, and very likely ported to the 0.92.x branch (and available in the next 0.92.2 version).

Thanks again!

Changed in inkscape:
assignee: nobody → jazzynico (jazzynico)
importance: Undecided → Low
milestone: none → 0.93
status: New → In Progress
jazzynico (jazzynico) wrote :

Fixed in the trunk rev. 15730.
Thanks for the patch, Mathieu!

Changed in inkscape:
assignee: jazzynico (jazzynico) → Mathieu GRENET (mgth)
status: In Progress → Fix Committed
jazzynico (jazzynico) wrote :

And backported to the lp:inkscape/0.92.x rev. 15434.

Mathieu GRENET (mgth) wrote :

Sorry, I did it wrong.
Testing with a bunch of svg I saw that Radial gradients often reference Linear Gradient Too.
So the best way I found is to simply remove the condition so it always work. Maybe people more aware than me could tell if there might be side effects.

I corrected some other problems in the patch with gradient origin and non significant 0.
Again sorry for my initial misunderstanding.

Mathieu GRENET (mgth) wrote :
To post a comment you must log in.
This report contains Public information  Edit
Everyone can see this information.

Other bug subscribers

Bug attachments