| 2017-02-27 00:33:42 |
Patrick Storz |
bug |
|
|
added bug |
| 2017-02-27 00:35:01 |
Patrick Storz |
description |
(follow up for bug #980527)
If a description spans multiple lines, i.e.
<description>
I want to
use multiple lines
and whitespace
</description>
it is not properly translated by gettext.
The reason is, that gettext removes whitespace in such a case and the string "I want to use multiple lines and whitespace" ends up in the "inkscape.pot" file.
Now to prevent exactly this issue one can set the 'xml:space="preserve"' attribute on the "description" which solves the issue by telling gettext to preserve all line breaks and other whitespace.
So far for the gettext side...
Inkscape is less picky. It *always* shows the text as if 'xml:space="preserve"' was specified. That is Inkscape *never* removes whitespace and always shows the string exactly as it's stored in the XML file. This is also the reason why the translation fails: Inkscape requests the translation for a string with newline characters and possibly repeated spaces and tabs, which gettext can't match.
This behavior leaves us with two quirks:
- If an extension author does not specify 'xml:space="preserve"' the message is untranslatable which is unexpected.
- The 'xml:space="preserve"' attribute has no real effect on the rendering of the string. It is more of a "workaround" for the descibed translation problem and does nothing beyond that.
Therefore I suggest two possible fixes:
1. The "proper" way to deal with this would be to make Inkscape actually respect the 'xml:space="preserve"' attribute when rendering the "description". This would mean that the sample above would in fact be shown as "I want to use multiple lines and whitespace" as Inkscape would remove any whitespace. This is the default for web browsers and the like and is also how Inkscape would render multiline text in a <text> node.
2. As this changes behavior it could change the appearance of some "description"s (obviously this would also be exactly those strings that are untranslatable right now). If this is something we really don't want one could solve it by keeping the behavior of Inkscape constant and simply implement a workaround for the gettext translation. This would effectively render the 'xml:space="preserve"' attribute useless as it would not offer any functionality.
Personally I'd certainly prefer option 1. as it solves all ambiguities and makes the 'xml:space="preserve"' attribute do something useful. Let me know if I should go ahead and implement this change! |
(follow up for bug #980527)
If a description spans multiple lines, i.e.
<description>
I want to
use multiple lines
and whitespace
</description>
it is not properly translated by gettext.
The reason is, that gettext removes whitespace in such a case and the string "I want to use multiple lines and whitespace" ends up in the "inkscape.pot" file.
Now to prevent exactly this issue one can set the 'xml:space="preserve"' attribute on the "description" which solves the issue by telling gettext to preserve all line breaks and other whitespace.
So far for the gettext side...
Inkscape is less picky. It *always* shows the text as if 'xml:space="preserve"' was specified. That is Inkscape *never* removes whitespace and always shows the string exactly as it's stored in the XML file. This is also the reason why the translation fails: Inkscape requests the translation for a string with newline characters and possibly repeated spaces and tabs, which gettext can't match.
This behavior leaves us with two quirks:
- If an extension author does not specify 'xml:space="preserve"' the message is untranslatable which is unexpected.
- The 'xml:space="preserve"' attribute has no real effect on the rendering of the string. It is more of a "workaround" for the described translation problem and does nothing beyond that.
Therefore I suggest two possible fixes:
1. The "proper" way to deal with this would be to make Inkscape actually respect the 'xml:space="preserve"' attribute when rendering the "description". This would mean that the sample above would in fact be shown as "I want to use multiple lines and whitespace" as Inkscape would remove any whitespace. This is the default for web browsers and the like and is also how Inkscape would render multiline text in a <text> node.
2. As this changes behavior it could change the appearance of some "description"s (obviously this would also be exactly those strings that are untranslatable right now). If this is something we really don't want one could solve it by keeping the behavior of Inkscape constant and simply implement a workaround for the gettext translation. This would effectively render the 'xml:space="preserve"' attribute useless as it would not offer any functionality.
Personally I'd certainly prefer option 1. as it solves all ambiguities and makes the 'xml:space="preserve"' attribute do something useful. Let me know if I should go ahead and implement this change! |
|
| 2017-02-27 00:35:55 |
Patrick Storz |
inkscape: assignee |
|
Eduard Braun (eduard-braun2) |
|
| 2017-02-27 00:36:44 |
Patrick Storz |
tags |
|
extensions |
|
| 2017-02-27 00:37:24 |
Patrick Storz |
bug |
|
|
added subscriber jazzynico |
| 2017-03-16 20:33:03 |
Patrick Storz |
attachment added |
|
bug1668115_v1.diff https://bugs.launchpad.net/inkscape/+bug/1668115/+attachment/4839085/+files/bug1668115_v1.diff |
|
| 2017-03-16 20:33:12 |
Patrick Storz |
inkscape: status |
New |
In Progress |
|
| 2017-03-25 16:24:29 |
Launchpad Janitor |
branch linked |
|
lp:inkscape |
|
| 2017-03-26 13:39:34 |
jazzynico |
inkscape: importance |
Undecided |
Low |
|
| 2017-03-26 13:39:34 |
jazzynico |
inkscape: status |
In Progress |
Fix Committed |
|
| 2017-03-26 13:39:34 |
jazzynico |
inkscape: milestone |
|
0.93 |
|
| 2017-03-26 13:39:50 |
jazzynico |
nominated for series |
|
inkscape/0.92.x |
|
| 2017-03-26 13:39:50 |
jazzynico |
bug task added |
|
inkscape/0.92.x |
|
| 2017-03-26 13:39:56 |
jazzynico |
inkscape/0.92.x: status |
New |
Triaged |
|
| 2017-03-26 13:39:59 |
jazzynico |
inkscape/0.92.x: importance |
Undecided |
Low |
|
| 2017-04-05 20:55:56 |
Launchpad Janitor |
branch linked |
|
lp:inkscape/0.92.x |
|
| 2017-04-05 20:58:27 |
Patrick Storz |
inkscape/0.92.x: assignee |
|
Eduard Braun (eduard-braun2) |
|
| 2017-04-05 20:58:30 |
Patrick Storz |
inkscape/0.92.x: status |
Triaged |
Fix Committed |
|
| 2017-04-06 04:19:36 |
jazzynico |
inkscape/0.92.x: milestone |
|
0.92.2 |
|
| 2017-04-24 16:25:29 |
chr[] |
attachment added |
|
Bildschirmfoto-inkscape-i18n-bug-0.92.png https://bugs.launchpad.net/inkscape/+bug/1668115/+attachment/4867368/+files/Bildschirmfoto-inkscape-i18n-bug-0.92.png |
|
| 2017-04-24 18:15:10 |
chr[] |
bug |
|
|
added subscriber chr[] |
| 2017-06-04 21:46:52 |
Patrick Storz |
tags |
extensions |
extensions-plugins |
|
| 2017-08-31 10:55:02 |
jazzynico |
inkscape/0.92.x: status |
Fix Committed |
Confirmed |
|
| 2017-08-31 10:55:04 |
jazzynico |
inkscape/0.92.x: status |
Confirmed |
Fix Released |
|
| 2019-03-08 13:49:44 |
Qantas94Heavy |
inkscape: status |
Fix Committed |
Fix Released |
|
