Comment 19 for bug 1663362

Alvin Penner (apenner) wrote :

  thanks for the patch. From the appearance of the synfig patch, it looks as if this should work correctly.
  However I am still confused as to the changes in the hpgl code. The synfig patch removes all the effects of rev 15444, which I believe is the correct thing to do. I do not understand why the hpgl patch does not do the same. I mean, why does the hpgl code have a compensation for document rotation in it?
    I did the following experiment just for curiosity. I reverted the file back to rev 15443. Then I created a new test file and rotated it by 40 degrees. Then I saved it as svg, and also saved it as hpgl, and then saved it as svg again, to see if it had changed. Then I viewed the hpgl file to confirm that it was correct, and then I compared the two svg files, from before and after, and confirmed that they were identical, apart from the file name which I had changed. So if the hpgl file is correct and if the svg file has not been corrupted, then why is it necessary to make any changes in the file? My understanding is that it is not possible for a Python output routine to corrupt the original svg file. I am not sure if that is the case for the internal extensions written in C, but I believe that is the case for the Python output extensions.
    Sorry for being a pest about this. I am not trying to give you a hard time, but I am trying to understand why these changes were necessary in the first place.